"scott.stark@jboss.org" wrote:
Hopefully that is resolved with the separation of the logging spi from jdk/log4j impls.

I'm repackaging AOP for the next 2.0.alpha, and am putting in the jars for jboss logging. I am in doubt about what to ship with though. The minimum needed to run is the jboss-logging-spi.jar, which uses the NullLoggerPlugin, so there is no logging.

In order to have any meaningful logging we would need to add jboss-logging-log4j.jar and log4j.jar. Are the any reasons why these should NOT be part of the aop download?

This mainly applies to people running aop standalone, in the app server all the necessary bits and pieces are obviously present.

I have integrated the logging stuff into AOP core. AspectManager.verbose is still the main switch for verbose logging from the AOP core classes.

Rather than doing:

Logger logger = Logger.getLogger(SomeClass.class);

Do

Logger logger = AOPLogger.getLogger(SomeClass.class);

AOPLogger is a subclass of Logger whose only function is to check if the chosen LoggerPlugin cannot be found, and if so to make sure we use a SystemOutLoggerPlugin I implemented. This prints out everything to System.out regardless of logging level.

So AspectManager.verbose turns on logging, and integrating with log4j allows more fine-grained control over what is logged.