0 Replies Latest reply on Aug 14, 2008 3:22 PM by Flavia Rainone

    Optmizing Pointcut matching in instrumentation

    Flavia Rainone Master

      While doing the optimization with the BindingCollection, I thought that it would be a good idea to do the same during instrumentation.

      https://jira.jboss.org/jira/browse/JBAOP-603

      At that time, my idea was to create a PointcutCollection, that would have methods for retrieval of pointcuts according to their type classification (execution, call, etc). This would be similar to BindingCollection, and I was considering the possibility of replacing this collection with a parameterized ClassifiedCollection for using with both binding and pointcuts.

      Now, I'm not as sure this optimization is worthy to do at this point, so close to the release. I see that Kabir has added a few checks that call the isCall, isWithin, etc, methods in AspectManager, avoiding the trigger of a transformation step when possible. Maybe those checks are enough and we don't need to retrieve classified pointcuts for transformation.

      What do you think, Kabir?