8 Replies Latest reply on Mar 19, 2008 12:15 PM by anil.saldhana

Broken object names in jacc

adrian.brock Mar 17, 2008 12:21 PM

I've done a basic fix to this, but I'm still seeing other problems.

The first I saw was object names without values, e.g.
jboss.jacc:id=,service=jacc
which is not a valid JMX object name.

Since you can't guarantee the a deployment unit doesn't contain
an invalid character for a JMX object name, I quoted the properties
in AbstractSecurityDeployer

But now I'm seeing this error when trying to run web integration tests

16:55:15,867 ERROR [AbstractKernelController] Error installing to Real: name=vfsfile:/home/ejort/jboss-head/testsuite/output/lib/class-loading.war state=PreReal mode=Manual requiredState=Real
org.jboss.deployment.DeploymentException: Error during install jboss.jacc:service=jacc,id=""
 at org.jboss.deployment.DeploymentException.rethrowAsDeploymentException(DeploymentException.java:52)
 at org.jboss.system.ServiceController.install(ServiceController.java:277)
 at org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:99)
 at org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:46)
 at org.jboss.deployers.spi.deployer.helpers.AbstractSimpleRealDeployer.internalDeploy(AbstractSimpleRealDeployer.java:62)
 at org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50)
 at org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174)

So there's obviously something wrong with the way you are generating
object names.

1. Re: Broken object names in jacc

anil.saldhana Mar 17, 2008 2:35 PM (in response to adrian.brock)

the id=something of the objectname is for the JACC context id of the deployment. Something like "id=ROOT.war" or id=jmx-console.war

Is there a particular test that displays this issue?
Actions

2. Re: Broken object names in jacc

anil.saldhana Mar 17, 2008 2:37 PM (in response to adrian.brock)

static final String BASE_OBJECT_NAME = "jboss.jacc:service=jacc,id=";

/**
 * Qualify the object name with parent name just to avoid conflicts
 * with deployments with the same name in multiple archives
 */
 private String getObjectName(DeploymentUnit unit)
 {
 String deploymentName = unit.getSimpleName();
 DeploymentUnit parentDU = unit.getParent();
 String parentDeploymentName = parentDU != null ?
 ",parent=" + parentDU.getSimpleName() : "";
 return BASE_OBJECT_NAME + deploymentName + parentDeploymentName;
 }

If deploymentunit.getSimpleName is blank, then id= is blank.

3. Re: Broken object names in jacc

adrian.brock Mar 17, 2008 2:43 PM (in response to adrian.brock)

org.jboss.test.web.test.WebIntegrationUnitTestCase
Actions
4. Re: Broken object names in jacc

adrian.brock Mar 17, 2008 2:45 PM (in response to adrian.brock)

"anil.saldhana@jboss.com" wrote:

If deploymentunit.getSimpleName is blank, then id= is blank.

What makes you think the simple name is unique?
It isn't.

e.g. you could have multiple deploy directories with a test.war
or you could have the same deployment name in "deploy" and "deployers"

Use the full name
Actions
5. Re: Broken object names in jacc

anil.saldhana Mar 17, 2008 3:04 PM (in response to adrian.brock)
"adrian@jboss.org" wrote:

Use the full name

DU.getName()
?
Actions
6. Re: Broken object names in jacc

adrian.brock Mar 18, 2008 1:55 PM (in response to adrian.brock)

I've found out why the simple name was coming back as the empty string
and fixed it.
http://jira.jboss.com/jira/browse/JBDEPLOY-18

But you still should really be using the full name (unless you have a mechanism
to override the object name when they conflict).
Actions
7. Re: Broken object names in jacc

anil.saldhana Mar 18, 2008 2:06 PM (in response to adrian.brock)

Thanks Adrian. You have answered the question I had in mind as to why certain deployments had empty simple names. I will be using the full name for the object names.
http://jira.jboss.org/jira/browse/JBAS-5322
Actions
8. Re: Broken object names in jacc

anil.saldhana Mar 19, 2008 12:15 PM (in response to adrian.brock)

The object name will contain the full vfs url within quotes obtained via unit.getName().
Actions

Go to original post