4 Replies Latest reply on Nov 23, 2009 8:01 PM by keibun

    [Struts Flow Editor Bug] any solution or advise for debuggin

    keibun Nov 20, 2009 7:55 AM

      I found bug in "Struts Flow Editor".

      my environment is
      ----------------------
      Eclipse: 3.4.2
      Struts Tools: 3.0.1
      ----------------------

      the bug I found is below
      ------------------------
      description:
      when "Action" has "Comment", drawing "Forward Link" causes
      some "Forward Link" line vanished.

      how to reproduce bug:
      1. you have "Action1" and "Action2"
      2. add Comment to "Action1"
      3. draw "Forward Link" line from "Action1" to "Action2".
      4. draw "Forward Link" line from "Action2" to "Action1".

      then line from Action2 to Aciton1 disappear from the screen.
      I found data file .strutsdia is not valid comparing to real struts-config.xml
      ------------------------

      I want bug fix or adivise for debuggin.

      I'm very new to Eclipse plugin developement,
      but I set up my eclipse which can enable step debugging and fixing code.

      I suspect struts data mode is corrupted when action has comment.

      for the first step I want to compare data model of struts flow ui between
      commented and not commented.

      I want to dump data model at
      /org.jboss.tools.struts/src/org/jboss/tools/struts/model/handlers/StrutsPasteHandler.java executeHandler().

      Is there good way to dump XModelObject tree so as to
      get useful information?

      any other useful debug technic is welcome.

      regard.

      • 13019 Views
      • Tags:
        • 1. Re: [Struts Flow Editor Bug] any solution or advise for debu
          scabanovich
          scabanovich Nov 20, 2009 9:00 AM (in response to keibun)

          Thanks, keibun! Your description is very helpful. I have created an issue in JIRA:
          https://jira.jboss.org/jira/browse/JBIDE-5236

          Here is my comment as to what is the cause of the issue:
          Initially there is null pointer exception in method resolveInternal() of class StrutsProcessHelper, because it treated comment objects in the same way as action objects, which was not correct. The exception was caught by method runTasks() to be logged, but because inconsistency in MANIFEST.MF, instance of log was not initialized, so that another null pointer happens, and having left uncaught, interrupts the update of diagram.

            • Actions
          • 2. Re: [Struts Flow Editor Bug] any solution or advise for debu
            keibun Nov 20, 2009 1:22 PM (in response to keibun)

            Thanks scabanovich!
            I'm surprised at your quick response and clear explanation.
            my team heavily use struts flow editor. I owe you very much, thank you!

            I want to contribute to development as much as posible,
            I'm very new to jboss community, so would you tell me
            some manner at the community?


            1. When finding problem which is better ?
            a. reporting to "develper forum"
            b. creating issue on JIRA.

            2. Is there any good develor tutorial for develper who want to
            send patch or participating develpment process.
            I'm also interested where most core jboss developer gathers, e.g mailing list or forums.

            3. Should I do something agains bug which I reported?
            Will this bug be fixed by someone and when?
            I'm not sure I can fix this bug quickly so I want to know
            how reported bug are treated in general.

              • Actions
            • 3. Re: [Struts Flow Editor Bug] any solution or advise for debu
              maxandersen
              maxandersen Nov 23, 2009 11:26 AM (in response to keibun)

               

              "keibun" wrote:
              Thanks scabanovich!
              I'm surprised at your quick response and clear explanation.
              my team heavily use struts flow editor. I owe you very much, thank you!

              I want to contribute to development as much as posible,
              I'm very new to jboss community, so would you tell me
              some manner at the community?


              I can try. Note, we don't do much on the struts tooling beyond major bugs fixing so we are looking for contributors wanting to help make them better ;)


              1. When finding problem which is better ?
              a. reporting to "develper forum"
              b. creating issue on JIRA.


              if you are not sure it is a bug, post to the forum and then if its recognized as a bug you will be asked to post the details in jira.
              if sure it is a bug, go to jira.


              2. Is there any good develor tutorial for develper who want to
              send patch or participating develpment process.
              I'm also interested where most core jboss developer gathers, e.g mailing list or forums.


              jboss.org/tools got all the details - I don't have a specific one for jboss tools development, but I really should make one.


              3. Should I do something agains bug which I reported?
              Will this bug be fixed by someone and when?
              I'm not sure I can fix this bug quickly so I want to know
              how reported bug are treated in general.


              We try and look at them all, but we might miss some. If you got a fix for a bug then please do not hesitate to say that and attach a patch.

                • Actions
              • 4. Re: [Struts Flow Editor Bug] any solution or advise for debu
                keibun Nov 23, 2009 8:01 PM (in response to keibun)

                max

                you answered my questions well,
                thank you.

                I can use bug reporting system by myself and send a patch if I have a solution for it.

                source code itself is documetation it's true but if there is well written comment or introductional documentation it helps newcommers.
                indeed I want jboss developer to improve and fix jboss tool code rather than to write documentations :-)

                regard

                  • Actions