11 Replies Latest reply on Sep 26, 2005 3:42 AM by Ulf Schroeter

    jmx-console update

    Ulf Schroeter Novice

      I would like to check in a modified version of the jmx console web application into CVS. This is a frame based version with a more concise and compact layout and simplified navigation (hopefully :-).

      As this is often a matter of taste and also has some impact on the layout of the web-consoleI would appreciate other point of view.

      Some screenshots and the modified jmx-console.war can be found here

      http://home.foni.net/~ulf-schroeter

      Regards
      Ulf

        • 1. Re: jmx-console update
          Scott Stark Master

          Can you submit it as a patch to jira for now so others can play around with its usability. The logo and color scheme definitely need to be updated as well.

          • 2. Re: jmx-console update
            Ulf Schroeter Novice

            >Can you submit it as a patch to jira for now so others can play around >with its usability.

            Thought that downloading the provided modifed jmx-console.war from http://home.foni.net/~ulf-schroeter/ and simply deploying it would be the fastest way to give it a try. Nevertheless I also will submit it as patch.


            >The logo and color scheme definitely need to be updated as well.

            Ok, I will replace the logo with the current one before patch submission. How can we get the 'right' color scheme (10 persons, 20 different views...) ? Is somewhere a suitable template available or should we keep the current jmx-console color scheme ?

            • 3. Re: jmx-console update
              Scott Stark Master

              I missed the war. We would want a jira issue anyway to document the change for the release notes.

              • 4. Re: jmx-console update
                Adrian Brock Master

                One thing I would like to see (but haven't had time to implement it)
                would be to change the TreeMap in org.jboss.jmx.adaptor.control.Server
                to use a custom comparator that orders by the domain then the "service=" or "type="
                then the "name=" the attributes when present.

                If you can make it order the JSR77 ObjectNames and display them more intuitively,
                even better... :-)

                • 5. Re: jmx-console update
                  Ulf Schroeter Novice

                  Ok, ordering by domain is already taking place as this is the first part of the object name. But how to sort mixed entries where one entry for example has a "service"/"type" attribute, but the other has not ? And how should object names like

                  jboss.management.local:EJBModule=PartnerService-v2.0.jar,J2EEApplication=PartnerService-v2.0.ear,J2EEServer=Local,j2eeType=EntityBean,name=local/StreetEntityBean
                  


                  be sorted ? Wouldn't it be a little bit confusing if we sort the whole name based on the trailing "name" attribute ? I am also wondering if the provided sample (taken from the jmx-console) is wellformed at all. According to the JSR77 spec an object name should have the a format

                  [domainName]:j2eeType=value,name=value,<parent-j2eeType>[,property=value]*
                  


                  e.g.

                  jboss.management.local:j2eeType=EntityBean,name=local/StreetEntityBean, EJBModule=PartnerService-v2.0.jar,J2EEApplication=PartnerService-v2.0.ear,J2EEServer=Local
                  




                  • 6. Re: jmx-console update
                    Adrian Brock Master

                     

                    "schrouf" wrote:
                    Ok, ordering by domain is already taking place as this is the first part of the object name. But how to sort mixed entries where one entry for example has a "service"/"type" attribute, but the other has not ? And how should object names like


                    I'm saying you order by what is has (service= probably taking precedence over type=?).

                    psuedo code
                    java.util.Comparator::compareTo(ObjectName first, ObjectName second)
                    {
                     // domain first
                    
                     // then the type/service
                     String type1 = getServiceOrType(first);
                     String type2 = getServiceOrType(second);
                     int comparison = type1.compareTo(type2);
                    }
                    


                    • 7. Re: jmx-console update
                      Adrian Brock Master

                       

                      "schrouf" wrote:
                      Wouldn't it be a little bit confusing if we sort the whole name based on the trailing "name" attribute ?


                      That's why I said JSR77 names would need special handling.
                      There should also be an option to "reorder the display" of the properties into something more
                      intuitive than alphabetical for names like this, e.g. JSR77 names are heirarchical

                      The JSR77 stuff would just be a "nice to have".
                      I find that whole section of the jmx-console completely unreadable.

                      • 8. Re: jmx-console update
                        Adrian Brock Master

                         

                        "schrouf" wrote:
                        I am also wondering if the provided sample (taken from the jmx-console) is wellformed at all. According to the JSR77 spec an object name should have the a format

                        [domainName]:j2eeType=value,name=value,<parent-j2eeType>[,property=value]*
                        


                        e.g.

                        jboss.management.local:j2eeType=EntityBean,name=local/StreetEntityBean, EJBModule=PartnerService-v2.0.jar,J2EEApplication=PartnerService-v2.0.ear,J2EEServer=Local
                        




                        Raise a bug report if it is wrong (and the bug report doesn't already exist).
                        Quote chapter and verse.

                        • 9. Re: jmx-console update
                          Ulf Schroeter Novice

                          Forget my bug assumption. I read the JSR77 specification on objectName (chapter 3.1.1.1, page 21) more carefully. The spec just requires an unordered set of key properties.

                          JSR77 excerpt

                          The J2EEManagedObject objectName consists of two parts:

                          - A domain name
                          - An unordered set of key properties, which must include the j2eeType, name and <parent-j2eeType> key properties.

                          The J2EEManagedObject name has the following syntax:

                          [domainName]:j2eeType=value,name=value,<parent-j2eeType>[,property=value]*


                          • 10. Re: jmx-console update
                            Elias Ross Master


                            By the way, I did a better JMX console for 3.2 and 4.0 and final don't have it. (In some ways better than what you have.)

                            Was anybody interested in getting this forward-ported to 4.0 or final?

                            Take a look:

                            http://wiki.jboss.org/wiki/attach?page=JMXConsole%2Fjmx-shutdown-1.jpg

                            http://request.developpez.com/j2ee/panorama/servers/jboss323/images/console2.png

                            • 11. Re: jmx-console update
                              Ulf Schroeter Novice

                              Hi genman,

                              this was my jmx-console proposal :-)

                              http://www.jboss.org/index.html?module=bb&op=viewtopic&t=67500

                              I haven't checked in that version, as I don't know who is finally responsible for things like layout, color schemes

                              regards
                              ulf