-
1. Re: JBAS-6875 discussion thread
brian.stansberry May 11, 2009 3:14 PM (in response to brian.stansberry)Now, just a couple implementation notes on this.
First, I don't think writing this data/jnp-service.url file is a proper function of the NamingService, so I'll write a separate service to do it and inject the NamingService as a source of information.
Second, the proper ultimate source of this URL(s) is org.jnp.server.Main, since that's who opens the socket. That will require a new release of jnp-server.jar. I'll ping Jason as to whether that's feasible for 5.1.0.GA. If not, for 5.1.x I'll just put the logic in the NamingService class, which is part of the AS codebase itself. Not ideal, but OK. -
2. Re: JBAS-6875 discussion thread
starksm64 May 11, 2009 4:28 PM (in response to brian.stansberry)I just did a 5.0.2.GA release for JBNAME-27 last week, but today is the freeze for naming comps. It would take me 15 mins to do another 5.0.3.GA naming release with a read-only bootstrapURL property. This can be null if the bootstrap port has been disabled.
-
3. Re: JBAS-6875 discussion thread
brian.stansberry May 11, 2009 5:20 PM (in response to brian.stansberry)I'm trying to track down someone to answer my question about 0.0.0.0. I wrote a simple method to create a List that I can move into org.jnp.server.Main in about 5 mins if that's what they want.
-
4. Re: JBAS-6875 discussion thread
brian.stansberry May 11, 2009 5:52 PM (in response to brian.stansberry)Just chatted with Ian and he says JON already has logic that recognizes a plugin config property with a value like "jnp://0.0.0.0:1099" and understands that the agent should connect via 127.0.0.1. So I think just writing that is fine. I'll add this in right now.
-
5. Re: JBAS-6875 discussion thread
starksm64 May 11, 2009 6:43 PM (in response to brian.stansberry)Is this going into the branch?
https://svn.jboss.org/repos/jbossas/projects/naming/branches/Branch_5_0 -
6. Re: JBAS-6875 discussion thread
brian.stansberry May 11, 2009 7:04 PM (in response to brian.stansberry)That's where I'm doing it yeah, unless you say not. I'd put it in trunk as well.
I'm about to commit it to the branch, but NamingMCUnitTestCase.testMainBean fails. Is that a known issue? I think I've commented out my change and the test for it, and I still see that failure. -
7. Re: JBAS-6875 discussion thread
starksm64 May 11, 2009 7:11 PM (in response to brian.stansberry)the Branch_5_0 is correct. I did see the NamingMCUnitTest fail, but when I looked at it the problem was that a jbossas instance was running and the test that failed was trying to do a lookup against localhost:1099, expecting that this was the test generated jndi tree. The test must not be validating how this is getting setup, so you can ignore the failure.
-
8. Re: JBAS-6875 discussion thread
brian.stansberry May 11, 2009 7:20 PM (in response to brian.stansberry)Thanks; that was it. I'm an idiot and forgotten I'd started an AS instance earlier.
This is checked in on Branch_5_0. -
9. Re: JBAS-6875 discussion thread
starksm64 May 11, 2009 7:26 PM (in response to brian.stansberry)Ok. I have assigned JBNAME-33 to the 5.0.3.GA release and will do that now.
-
10. Re: JBAS-6875 discussion thread
brian.stansberry May 11, 2009 7:49 PM (in response to brian.stansberry)Thanks; it's done in trunk as well. I added a List property there as Main accepts multiple bind addresses.
-
11. Re: JBAS-6875 discussion thread
starksm64 May 11, 2009 7:52 PM (in response to brian.stansberry)The 5.0.3.GA release has been uploaded to the svn repository:
https://svn.jboss.org/repos/repository.jboss.org/maven2/org/jboss/naming/
I'll let you update jbossas to the new version. -
12. Re: JBAS-6875 discussion thread
brian.stansberry May 12, 2009 2:19 PM (in response to brian.stansberry)Both trunk and Branch_5_x are updated. Thanks again, Scott.