9 Replies Latest reply on May 22, 2008 2:44 AM by vickyk

    JBAS-5023

    alesj

       

      "vicky" wrote:

      After spending some time in understanding the root cause of this issue
      http://jira.jboss.com/jira/browse/JBAS-5023
      I realized that the RARParserDeployer does not parse jboss-ra.xml , this seems to be missing in the RARDeployer right now .
      Adrian can you confirm this ?


        • 1. Re: JBAS-5023

          That looks correct. This goes with the other task to be able to parse multiple files
          in one parsing deployer.

          • 2. Re: JBAS-5023
            alesj

             

            "adrian@jboss.org" wrote:
            This goes with the other task to be able to parse multiple files
            in one parsing deployer.

            This looks more critical than stated here (search for 184):
            - http://www.jboss.com/?module=bb&op=viewtopic&t=124368
            - http://www.jboss.com/?module=bb&op=viewtopic&t=118600&start=30

            Should I focus on this (instead of the broken/deprecated deployer test)? :-)
            Or can this be done in the similar merging fashion as the rest of JBossMetaData?

            Since it looks like Vicky will need this in order to pick-up this task.

            • 3. Re: JBAS-5023

              I don't see why it is critical?

              jboss-ra.xml is a new feature in JBoss5 that Weston did only in the old deployer
              (which isn't used). So nobody is using this feature except the testsuite.

              With the profile service its main use case (being able to override ra.xml properties)
              is pretty much redundant.
              It was really redundant anyway because you could always just modify the ra.xml

              Its only other use would be allow classloader config but in the new deployers you will be able
              to add a META-INF/jboss-classloader.xml to achieve the same purpose.

              184 is a feature we can do in RC1 since it only affects how deployers are implemented
              when they need to parse more than one file, in this case ra.xml and jboss-ra.xml
              Currently you write two parsing deployers which is messy.

              • 4. Re: JBAS-5023
                vickyk

                Since this is done
                http://jira.jboss.com/jira/browse/JBDEPLOY-4

                so we should be able to rewrite the RARDeployer which will parse ra.xml/jboss-ra.xml in one go .

                Ales , are we ready for it now ?

                • 5. Re: JBAS-5023
                  alesj

                   

                  "vickyk" wrote:
                  Ales , are we ready for it now ?

                  Sure, the task is resolved. ;-)

                  • 6. Re: JBAS-5023
                    jesper.pedersen

                    Vicky, do you have some cycles to complete this task ?

                    • 7. Re: JBAS-5023
                      vickyk

                       

                      "jesper.pedersen" wrote:
                      Vicky, do you have some cycles to complete this task ?

                      Yes I have started looking into this .

                      Ales , I have been trying to figure out for the changes to be made in the RAR deployers so was trying to build and run the test from here
                      http://anonsvn.jboss.org/repos/jbossas/projects/jboss-deployers/trunk

                      I do get this error
                      C:\Documents and Settings\Vicky.JBOSS-VICKY\workspace\jboss-deployers>mvn instal
                      l
                      [INFO] Scanning for projects...
                      [INFO] Reactor build order:
                      [INFO] JBoss Deployers Build
                      [INFO] JBoss Deployers Core SPI
                      [INFO] JBoss Deployers Core
                      [INFO] JBoss Deployers Client SPI
                      [INFO] JBoss Deployers Client
                      [INFO] JBoss Deployers Structure SPI
                      [INFO] JBoss Deployers SPI
                      [INFO] JBoss Deployers Impl
                      [INFO] JBoss Deployers VFS SPI
                      [INFO] JBoss Deployers VFS
                      [INFO] JBoss Deployers Aggregator
                      WAGON_VERSION: 1.0-beta-2
                      [INFO] -------------------------------------------------------------------------
                      ---
                      [INFO] Building JBoss Deployers Build
                      [INFO] task-segment: [install]
                      [INFO] -------------------------------------------------------------------------
                      ---
                      Downloading: http://repo1.maven.org/maven2/org/jboss/maven/plugins/maven-jboss-d
                      eploy-plugin/1.6/maven-jboss-deploy-plugin-1.6.jar
                      [INFO] ------------------------------------------------------------------------
                      [ERROR] BUILD FAILURE
                      [INFO] ------------------------------------------------------------------------
                      [INFO] A required plugin was not found: Plugin could not be found - check that t
                      he goal name is correct: Unable to download the artifact from any repository
                      
                      Try downloading the file manually from the project website.
                      
                      Then, install it using the command:
                       mvn install:install-file -DgroupId=org.jboss.maven.plugins -DartifactId=mave
                      n-jboss-deploy-plugin \
                       -Dversion=1.6 -Dpackaging=maven-plugin -Dfile=/path/to/file
                      Alternatively, if you host your own repository you can deploy the file there:
                       mvn deploy:deploy-file -DgroupId=org.jboss.maven.plugins -DartifactId=maven-jb
                      oss-deploy-plugin \
                       -Dversion=1.6 -Dpackaging=maven-plugin -Dfile=/path/to/file \
                       -Durl=[url] -DrepositoryId=[id]
                      
                      
                       org.jboss.maven.plugins:maven-jboss-deploy-plugin:maven-plugin:1.6
                      
                      from the specified remote repositories:
                       central (http://repo1.maven.org/maven2)
                      
                       org.jboss.maven.plugins:maven-jboss-deploy-plugin:maven-plugin:1.6
                      
                      from the specified remote repositories:
                       central (http://repo1.maven.org/maven2)
                      
                      [INFO] ------------------------------------------------------------------------
                      [INFO] For more information, run Maven with the -e switch
                      [INFO] ------------------------------------------------------------------------
                      [INFO] Total time: 5 seconds
                      [INFO] Finished at: Tue May 20 23:22:11 IST 2008
                      [INFO] Final Memory: 5M/10M
                      [INFO] ------------------------------------------------------------------------
                      






                      • 8. Re: JBAS-5023
                        alesj
                        • 9. Re: JBAS-5023
                          vickyk