1 2 Previous Next 20 Replies Latest reply on Jul 9, 2005 3:35 PM by mikezzz Go to original post
      • 15. Re: Working on JBMAIL-10
        acoliver

        eliminate tabs. they are bad. Code should be readable. We format like this:

        ...
        public foo() { //same line { the way GOD HIMSELF intended.
        if (foo != bar) {
        //4 spaces at each.
        }
        }
        ...

        But I don't really care so long as its readible and their aren't tabs and CVS does the proper ^M conversion (no samba copies and weird stuff). Its best if everyone does as above because the bulk of the JBMS code is written that way, but who cares so long as you can read it and the DIFFS aren't all formatting changes. (If you DO format, do that as a seperate commit than the actual change)

        • 16. Re: Working on JBMAIL-10
          acoliver

          it removed the spaces.... +4 at each level

          • 17. Re: Working on JBMAIL-10
            jeff87

            OK, I got the latest of that file from cvs and did a copy & paste of just my changes to the code. No telling Eclipse to format the file this time. It's uploaded.

            Thanks,
            Jeff

            • 18. Re: Working on JBMAIL-10

              Is committed. Thank you!

              Mike.

              • 19. Re: Working on JBMAIL-10
                jeff87

                Great! Thanks Mike and Andy for all your help. What should I look at next? Perhaps the build file to see why I can't run with dev-deploy but yet I can with the deploy task?

                Thanks,
                Jeff

                • 20. Re: Working on JBMAIL-10

                  Go for it!

                  Mike.

                  1 2 Previous Next