4 Replies Latest reply on May 23, 2005 3:38 PM by Adrian Brock

    AOP/MC integration update

    Bill Burke Master

      The AOP/MC integration is starting to look more complete. I've started on an AOP SchemaBinding, that works for a few things and that can register aspect factories with the microcontainer. I've also tested aspects with a dependency and a bean that has that aspect to make sure all the dependency propagation works.

      All I'm waiting for now to finish the XML stuff is the the XSD:ANY integration for SchemaBindings so that I can embed definitions within AOP XML and definitions within BEAN XML (for annotation overrides and such). Currently I'm testing bean within AOP xml with CDATA.

      If you're interested in the tests, they are here:

      aspects/src/resource/test/kernel/*.xml
      aspects/src/test/org/jboss/test/AspectXmlTestCase.java

      I redid the GenericBeanFactory. The IMPL for it is here:

      aspects/src/main/org/jboss/aspects/kernel/AspectBeanFactory.java

      Since the AOP Schema will create BeanMetaData directly, I can stuff this as a property of the AspectBeanFactory.

      The Schema Binding is here:

      aspects/src/main/org/jboss/aspects/kernel/schema/..

        • 1. Re: AOP/MC integration update
          Adrian Brock Master

          I've spent some more time this morning fixing these tests.
          I'm down to one test failing, I don't see why it is making this assertion:

          AspectTestCase.

           assertFalse("TODO: Is this test supposed to be failing?", obj instanceof Delegate);
          previously this was
           assertTrue(! (obj instanceof Delegate));
          


          • 2. Re: AOP/MC integration update
            Bill Burke Master

            which test case? One of the tests is proxy based, the other tests load-time instrumentation.

            • 3. Re: AOP/MC integration update
              Bill Burke Master

              BTW, I don't know if I've said this already, but I had done nothing to integrate this tests with ant.

              • 4. Re: AOP/MC integration update
                Adrian Brock Master

                The test is working find from ant after I fixed the classpath to include the xml.

                "adrian@jboss.org" wrote:

                AspectTestCase.

                 assertFalse("TODO: Is this test supposed to be failing?", obj instanceof Delegate);
                previously this was
                 assertTrue(! (obj instanceof Delegate));
                


                To be more explicit:
                <testcase classname="org.jboss.test.kernel.AspectTestCase" name="testDependencyCorrectOrder" time="0.086">
                 <failure message="TODO: Is this test supposed to be failing?" type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError: TODO: Is this test
                supposed to be failing?
                 at org.jboss.test.kernel.AspectTestCase.testDependencyCorrectOrder(AspectTestCase.java:176)
                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                </failure>
                 </testcase>