1 Reply Latest reply on Aug 28, 2007 5:53 PM by Ales Justin

    Wrong methods on KernelControllerContext

    Adrian Brock Master

      While looking at the scoping changes, I discovered some wrong methods
      on the KernelControllerContext.

      To repeat what I said before, most of the runtime state/config should be done
      through the DependencyInfo not the ControllerContext.

      Where the ControllerContext holds state it is simply useful information
      to prevent repeated access/construction, e.g. BeanInfo in the POJO stuff
      or the legacy ServiceContext in the MBean stuff.

      I removed applyMetaData() since that was completely unnecessary.
      I factored out the MetaDataVisitor implementations from AbstractKernelControllerContext
      to make it obvious that this stuff doesn't need to be in the context and is entirely
      orthogonal.

      I moved isAutowireCandidate() to the DependencyInfo where it belongs.

        • 1. Re: Wrong methods on KernelControllerContext
          Ales Justin Master

           

          "adrian@jboss.org" wrote:

          I removed applyMetaData() since that was completely unnecessary.
          I factored out the MetaDataVisitor implementations from AbstractKernelControllerContext
          to make it obvious that this stuff doesn't need to be in the context and is entirely orthogonal.

          Yup, I agree.
          But since this was still stuck in AbstractKernelControllerContext, the applyMetaData was necessary. :-)
          If you just hinted this when I was splitting the initial visit ... ;-)