JBossDeveloper

"alesj" wrote:
OK, this is deeper problem, than I anticipated earlier.

There is a problem of interfaces/abstract classes.

A List<E> is reconstructed as a java.util.ArrayList<E>; a Set<E> as a java.util.HashSet<E>; a SortedSet<E> as a java.util.TreeSet<E>.

"adrian@jboss.org" wrote:

Generically, we could allow some kind of plugin mechanism to allow
somebody to configure:
interface -> implementation class or factory

"alesj" wrote:

"adrian@jboss.org" wrote:

Generically, we could allow some kind of plugin mechanism to allow
somebody to configure:
interface -> implementation class or factory

Even for non collection classes?
The composite ones.
Doesn't that defeat the whole purpose of OO? :-)

@ManagementProperty
public void setSomething(Interface i) {}

public interface Interface
{
 void setInteger(int i);
 void setString(String s);
}

"adrian@jboss.org" wrote:

1) Create a proxy
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/trunk/mbeans/src/main/org/jboss/mx/mxbean/CompositeDataInvocationHandler.java?revision=57108&view=markup

The proxy approach doesn't work for collections since they aren't javabeans.

"adrian@jboss.org" wrote:

I don't get the reference to OO?

"alesj" wrote:

If we only remember its interface and then have a map 'interface --> default impl', then we forget about polymorphism.
e.g. I would still like to have MyInterface1 and MyInterface2, both implementing Interface, taken apart, but when I want to re-construct them, I very much care about the impl details.

OK, I'll use the proxy approach if the TypeInfo passed in for Composite is interface, otherwise I'll use the info to reconstruct the instance.

But this means some details could get lost:

public class Pojo
...
public class SubPojo extends Pojo
...
MetaValue mv = MVF.create(new SubPojo(), Pojo.class);
SubPojo sp = MVF.unwrap(mv); // failed!!

Alexey had some more problems:

I think I figured it out...

AbstractManagedObjectFactory:
 public ManagedObject buildManagedObject(Class<? extends Serializable> clazz)
{
 if (managed)
 {
 TypeInfo typeInfo = propertyInfo.getType();
 if( typeInfo.isArray() || typeInfo.isCollection() )
 metaType = new ArrayMetaType(1, MANAGED_OBJECT_META_TYPE);
 else
 metaType = MANAGED_OBJECT_META_TYPE;
 }
 else
 {
 metaType = metaTypeFactory.resolve(propertyInfo.getType());
 }

should create CollectionMetaType for collections.

I'll update it.