-
15. Re: MC upgrade breaks scoped aop tests in trunk
"alesj" wrote:
"kabir.khan@jboss.com" wrote:
I think you or Adrian need to do it
Why us?
It's your feature. ;-)
It worked for about a year, now it suddenly doesn't."alesj" wrote:
"kabir.khan@jboss.com" wrote:
I'm not 100% clear on what Adrian means
As much as I could follow, he's just trying to say you need
to prepare metadata properly and things should work.
Easy. :-)
The classloader to be used needs to be overridable at runtime for the reasons I have explained. When deploying the beanfactory it uses the correct classloader, but when it comes to creating aspect instances I need to be able to pass in the classloader.
Anyway, if you're happy with me changing GBF I can do that. Is there anything I should be aware of? -
16. Re: MC upgrade breaks scoped aop tests in trunk
In the worst case, why don't you create your own GBF,
it's not like you need a lot of features from the original, or do you?
(hence little duplication)
Interesting idea. I could maybe have my AspectBeanMetaDataFactory create a different impl. If GBF.createBean(ClassLoader cl) could be made protected rather than private there would be no duplication whatsoever. -
17. Re: MC upgrade breaks scoped aop tests in trunk
"kabir@jboss.org" wrote:
If GBF.createBean(ClassLoader cl) could be made protected rather than private there would be no duplication whatsoever.
I think this can be easily arranged. :-)
btw: weird forum behavior - your post is under my name :-) -
18. Re: MC upgrade breaks scoped aop tests in trunk
"alesj" wrote:
"kabir@jboss.org" wrote:
If GBF.createBean(ClassLoader cl) could be made protected rather than private there would be no duplication whatsoever.
I think this can be easily arranged. :-)
I've changed it to protected
+ ported your OverrideCL test from Branch_2_0.
So, Kabir, can you fix this (+ add JIRA) in the trunk
and I'll port the changes then to Branch_2_0? -
19. Re: MC upgrade breaks scoped aop tests in trunk
"alesj" wrote:
"alesj" wrote:
"kabir@jboss.org" wrote:
If GBF.createBean(ClassLoader cl) could be made protected rather than private there would be no duplication whatsoever.
I think this can be easily arranged. :-)
I've changed it to protected
+ ported your OverrideCL test from Branch_2_0.
So, Kabir, can you fix this (+ add JIRA) in the trunk
and I'll port the changes then to Branch_2_0?
Thanks, I'll let you know when I am done -
21. Re: MC upgrade breaks scoped aop tests in trunk
I reopened the JIRA issuse. Please close it when you have ported the changes Branch_2_0
-
22. Re: MC upgrade breaks scoped aop tests in trunk
"kabir.khan@jboss.com" wrote:
I reopened the JIRA issuse. Please close it when you have ported the changes Branch_2_0
Can you run those JBossAS tests with this change?
Or at least some portion of them ...
I'll deploy 2.2.0-SNAPSHOT for you. -
23. Re: MC upgrade breaks scoped aop tests in trunk
"alesj" wrote:
Can you run those JBossAS tests with this change?
I did that already, the AS aop tests, aop-mc-int tests and your demo all pass -
24. Re: MC upgrade breaks scoped aop tests in trunk
"kabir.khan@jboss.com" wrote:
"alesj" wrote:
Can you run those JBossAS tests with this change?
and your demo all pass
Even my demo, nice! :-)
Thanks!
I'll port this to Branch_2_0 and do a new MC/Kernel release.