This content has been marked as final.
Show 4 replies
-
1. Re: TxInterceptor logging of exceptions
manik Jan 30, 2007 11:46 AM (in response to brian.stansberry)
1) Why log at all if the exception is going to be rethrown? The log doesn't indicate any action on the part of the interceptor. Eviction now uses a 0 ms timeout, so a lot of those timeouts could end up getting logged.
Agreed. Unless we intend to NOT throw the exception (failSilently is present) we should not log the exception.
2) If failSilently is set, a stack trace in the log at INFO doesn't seem very silent. People freak at stack traces no matter what level. At a minimum I think any INFO logging should be just the message, with a stack trace only at DEBUG or TRACE. But with Hibernate's usage, I think these are going to be too frequent for INFO.
+1 as well. -
2. Re: TxInterceptor logging of exceptions
brian.stansberry Jan 30, 2007 12:14 PM (in response to brian.stansberry)"manik.surtani@jboss.com" wrote:
+1 as well.
To logging the message INFO and the stack trace lower, or the whole thing lower? -
3. Re: TxInterceptor logging of exceptions
manik Jan 30, 2007 1:37 PM (in response to brian.stansberry)Sorry, shld have specified - the whole thing for lower.
-
4. Re: TxInterceptor logging of exceptions
brian.stansberry Jan 30, 2007 1:46 PM (in response to brian.stansberry)Cool. Done.