Discovery of Tomcat on windows and discovery of JMXServers

[carlabramsson]

Hello!

I've made some improvements of the Tomcat-plugin. The version in the trunk doesn't play nice with Tomcat on windows (or the default service wrapper for windows that Tomcat comes with).

Also, I've found a solution for the JDK6-based discovery of JMXServers without the drawback of creating a new resource each time the JVM gets a new PID. My workaround for this is to let the DiscoveryBean connect to the JMXServer via the PID-url and extract the port of the MBeanServer via JMX instead of parsing the commandline-args. I guess it's possible to do the same for Tomcat.

Are these patches of interest?

BTW, we are now testing the current beta on 30 servers and a total of 2000+ services. ;-)

[mazz]

I'll let Jay S. discuss with you the Tomcat stuff. He's working on that.

I would say that, yes, those patches would be of interest. Have you discussed getting a contributor agreement?

Hop on #jopr (freenode) if you want to discuss the contributor agreement further.

Its cool that you have 30 servers! :) Nice to know people are using the HA stuff.

[mazz]

BTW, we are now testing the current beta on 30 servers and a total of 2000+ services. ;-)

Er... or did you mean 30 MANAGED servers? I thought you meant 30 Jopr Servers :) I think you meant the former... its still cool though ! :)

[jayshaughnessy]

Hi, Sounds interesting. What issues were you having with Windows? What wasn't playing nice? It's been working in our tests here but we certainly may have missed something...

[carlabramsson]

The problem we had was with the autodiscovery of Tomcat. If you start tomcat on windows with a script (.bat) it's detected correctly, but if you use the service wrapper bundled with Tomcat (tomcat6.exe / tomcat6w.exe) the process isn't picked up by the process-scan since it's looking for "java.*" and the process is named "tomcat6.exe".

But even if you fix this you are going to run into problems after this when you try to parse values from the cmd args (and also when you extract the install dir). The tomcat6.exe process has no cmd args that are jvm args, thoose are stored in the config for the wrapper itself and passed along to the JVM after the wrapper is started (kinda).

[pilhuhn]

Hi,
can you please open a jira at http://jira.jboss.org/jira/browse/JOPR

thanks
Heiko

[jayshaughnessy]

I've added https://jira.jboss.org/jira/browse/JOPR-160 on behalf of this topic.

Carl, If you are interested in supplying your patches for possible inclusion please look into getting a contributor's agreement as mazz mentioned earlier: "Hop on #jopr (freenode) if you want to discuss the contributor agreement further."