Problem with NotificationBroadcasterSupport?

[davidjencks]

The current implementation of NotificationBroadcasterSupport seems to give a ConcurrentModificationException if the result of the notification is to remove one of the listeners. Is this a bug?

I would like to know whether to fix this by writing my own broadcaster support in my class or if I can fix it in jbossmx by copying the list before iterating in the jmx class.

[juha]

clone the list

-- Juha

[juha]

well actually that sucks...

you gonna clone every time you send a notification?

poopoo

add/remove listeners on a copy, and make that the current active list once you're done iterating the list of listeners.

-- Juha

[davidjencks]

That would be ok if sendNotification was synchronized. Otherwise the semantics seem a little vague... in fact even the
Iterator listenerIterator = new ArrayList(listenerMap.keySet()).iterator();

solution should be synchronized on listenerMap as should the add/remove listener methods.

(doesn't look like Set extends Cloneable).

Are you OK with all this synchronization? If not I will write something in my class. I don't want to write the add/remove modifies copy right now.

[juha]

yea go ahead

either that or use OSWEGO, the iterators never throw CME (but you need to explicitly deal with null values)