-
1. Re: jboss.tomcat.connectors.started JMX Notification Gone?
dimitris Feb 13, 2009 4:44 AM (in response to jbrow)I see you've already created a JIRA for that:
https://jira.jboss.org/jira/browse/JBAS-6499
It looks like when Brian refactored the service, he left this out for some reason. -
2. Re: jboss.tomcat.connectors.started JMX Notification Gone?
jbrow Feb 13, 2009 4:56 AM (in response to jbrow)Thanks, Dimitris. Do I just uncomment the call and rebuild JBossAS, or is there a legitimate reason why it's commented out?
Thanks! -
3. Re: jboss.tomcat.connectors.started JMX Notification Gone?
dimitris Feb 13, 2009 6:00 AM (in response to jbrow)I'll let Brian answer.
-
4. Re: jboss.tomcat.connectors.started JMX Notification Gone?
brian.stansberry Feb 13, 2009 9:32 AM (in response to jbrow)I didn't change this; when I did the refactor that line was already as it is now. I'm looking now at the history on the 5.x and 4.x branch to see if I can figure out why it's commented.
-
5. Re: jboss.tomcat.connectors.started JMX Notification Gone?
brian.stansberry Feb 13, 2009 10:10 AM (in response to jbrow)As far back as svn history goes on Branch_5_0 fka trunk (15/Mar/07, in the TomcatDeployer class) this is commented out. In Branch_4_0 it was added on 4/25/05, r 30817 in the Tomcat5 class. That same commit included a change to the equivalent class in trunk. I can't figure out how to see the contents of that commit though; perhaps it inadvertently just wasn't uncommented in the trunk change.
-
6. Re: jboss.tomcat.connectors.started JMX Notification Gone?
brian.stansberry Feb 13, 2009 10:45 AM (in response to jbrow)Not 100% sure but I think this got dropped when the old Branch_4_2 JBossWeb class got merged into the TomcatDeployers class in trunk (later Remy and I broke it back out.)
Bottom line though I don't see any reason jbrow shouldn't re-enable the notification. -
7. Re: jboss.tomcat.connectors.started JMX Notification Gone?
dimitris Feb 13, 2009 11:28 AM (in response to jbrow)If you're going to re-enable this in Branch_5_x look for the symmetrical shutting down notification, as well.
-
8. Re: jboss.tomcat.connectors.started JMX Notification Gone?
jbrow Feb 13, 2009 3:06 PM (in response to jbrow)Thanks Dimitris and Brian for looking into this!
"dimitris@jboss.org" wrote:
If you're going to re-enable this in Branch_5_x look for the symmetrical shutting down notification, as well.
I don't believe there is a symmetrical shut-down notice. I think the 4.x branch just depended upon the "org.jboss.system.server.stopped" generic JMX notification. -
9. Re: jboss.tomcat.connectors.started JMX Notification Gone?
dimitris Feb 16, 2009 4:11 AM (in response to jbrow)I think you are right about the shutting down notification! My bad.
-
10. Re: jboss.tomcat.connectors.started JMX Notification Gone?
rmaucher Feb 17, 2009 9:23 AM (in response to jbrow)Connector start is very similar now: it comes from the start notification of JBoss. So adding it back is not so useful, but it does compatibility.
/** * Used to receive notification of the server start msg so the tomcat connectors can be started after all web apps * are deployed. */ public void handleNotification(Notification msg, Object handback) { String type = msg.getType(); if (type.equals(Server.START_NOTIFICATION_TYPE)) { log.debug("Saw " + type + " notification, starting connectors"); try { startConnectors(); } catch (Exception e) { log.warn("Failed to startConnectors", e); } } if (type.equals(Server.STOP_NOTIFICATION_TYPE)) { log.debug("Saw " + type + " notification, stopping connectors"); try { stopConnectors(); } catch (Exception e) { log.warn("Failed to stopConnectors", e); } } }
-
11. Re: jboss.tomcat.connectors.started JMX Notification Gone?
jbrow Feb 17, 2009 2:50 PM (in response to jbrow)"remy.maucherat@jboss.com" wrote:
Connector start is very similar now: it comes from the start notification of JBoss. So adding it back is not so useful, but it does compatibility.
Since this method is "handleNotification()", doesn't that mean the JMX notification has already been sent before the connectors are up and running?