tc5-cluster-service.xml's ClusterName attribute

[jrostosk]

Shouldn't TreeCache's ClusterName attribute in tc5-cluster-service.xml use the system property ${jboss.partition.name} instead of the hardcoded value 'Tomcat-Cluster'? Its ClusterConfig attribute now uses ${jboss.partition.udpGroup} (nice).


These two attributes appear to be directly analogous to the following two ClusterPartition attributes in cluster-service.xml:

attribute PartitionName uses ${jboss.partition.name}
attribute PartitionConfig uses ${jboss.partition.udpGroup}

[brian.stansberry]

Good suggestion :-)

How about the following?

<attribute name="ClusterName">${jboss.partition.name:DefaultPartition}-Tomcat</attribute>

This attribute drives the group name given to the JGroups channel. Technically speaking, appending "-Tomcat" isn't necessary, as the tc5-cluster-service JGroups channel needs to use different addresses/ports from the cluster-service one. But my gut tells me its better to have different group names as well, maybe just to help avoid confusing people reading logs, etc.

[jrostosk]

Regarding the value

${jboss.partition.name:DefaultPartition}-Tomcat

, I agree that that's a good naming convention, even though the name doesn't technically matter, as you said.

Will we see this in 4.0.4?

[brian.stansberry]

Yep, it's in CVS now. See http://jira.jboss.com/jira/browse/JBAS-2760.

Note we went with

<attribute name="ClusterName">Tomcat-${jboss.partition.name:Cluster}</attribute>

to preserve simple interoperability with previous versions of JBossAS.

Thanks for the suggestion!