JRMPInvoker need to implement NotificationBroadcaster

[lretief]

I notice when I am using DR4 that whenever I shutdown I get this exception:

java.lang.IllegalArgumentException: The MBean jboss:service=invoker,type=jrmp exists but does not implement the NotificationBroadcaster interface.

Looking at the code in HEAD it seems that this is in fact still the case. Anybody working on this? If not, should I take a look?

[ivelin.ivanov]

Take a look at it.

Ivelin

[lretief]

I have submitted a patch. I now notice a similar problem with RMIClassLoader. Can I go ahead there as well?

Caused by: java.lang.IllegalArgumentException: The MBean jboss.rmi:type=RMIClassLoader exists but does not implement the NotificationBroadcaster interface.
... 62 more

[starksm64]

Thanks for looking, but the patch is not valid and making other mbeans implement NotificationBroadcaster is not the way to address the exception. The real problem is that the org.jboss.management.j2ee.MBean class only registers for notification on mbeans that implement javax.management.NotificationBroadcaster, but it unconditionally tries to unregister on all mbeans. The type of exception must have changed such that the current MBean.preDestruction try/catch block is incorrect. The correct change is only to unregister with those mbeans previously the MBean code register as a listener of.

[lretief]

Ah... I thought something like this was probably going on behind the scenes. Is someone working on org.jboss.management.j2ee.MBean or can I have a bash at that?

[starksm64]

Yes, see if you can track whether the associated jbossServiceName did support NotificationBroadcaster and only remove the listener if it was added.