I have refactored CoreSubscription related code so it no longer contains any references to JMS concepts such as as client id and selector string.
The CoreSubscription deals with a Filter for filtering it's messages.
Sub classes Subscription and DurableSubscription now exist in the JMS facade and apply the JMS attributes (client id, selector string and no local).
I have also removed any code from the core classes that was only there to provide mbean attributes and operations. Core code shouldn't be polluted with mbean stuff.
I have shifted this code to the Queue and Topic mbeans where i think it belongs.
While I was there I have fixed the bug with selectors and subscriptions JBMESSAGING-325