12 Replies Latest reply on Jan 20, 2007 9:19 PM by ovidiu.feodorov

Non connected remoting clients throwing java.lang.Exception

clebert.suconic Jan 18, 2007 4:58 PM

I guess we have changed remoting to disconnect clients when ConnectionValidator fails, and I have seen situations where invocations are failing on the testsuite.

FailoverTest(Clustering)::testFailoverMessageOnServer2 is an example of such behavior.

I guess we should change (or ask remoting team to do it), in such way We should not disconnect remoting clients... or at least throw a meaninful Exception we could catch on FailoverValveInterceptor.

This is the exception we are catching now:

java.lang.Exception: Can not make remoting client invocation due to not being connected to server.
at org.jboss.remoting.Client.invoke(Client.java:639)
at org.jboss.remoting.Client.invoke(Client.java:627)
at org.jboss.jms.client.delegate.DelegateSupport.invoke(DelegateSupport.java:118)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.container.StateCreationAspect.handleCreateConsumerDelegate(StateCreationAspect.java:153)
at org.jboss.aop.advice.org.jboss.jms.client.container.StateCreationAspect17.invoke(StateCreationAspect17.java)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.container.ConsumerAspect.handleCreateConsumerDelegate(ConsumerAspect.java:67)
at org.jboss.aop.advice.org.jboss.jms.client.container.ConsumerAspect16.invoke(ConsumerAspect16.java)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.container.ClosedInterceptor.invoke(ClosedInterceptor.java:177)
at org.jboss.aop.advice.PerInstanceInterceptor.invoke(PerInstanceInterceptor.java:117)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.container.ExceptionInterceptor.invoke(ExceptionInterceptor.java:71)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.container.FailoverValveInterceptor.invoke(FailoverValveInterceptor.java:112)
at org.jboss.aop.advice.PerInstanceInterceptor.invoke(PerInstanceInterceptor.java:117)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.container.ClientLogInterceptor.invoke(ClientLogInterceptor.java:107)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.delegate.ClientSessionDelegate.createConsumerDelegate(ClientSessionDelegate.java)
at org.jboss.jms.client.JBossSession.createConsumer(JBossSession.java:254)
at org.jboss.jms.client.JBossSession.createConsumer(JBossSession.java:226)
at org.jboss.test.messaging.jms.clustering.FailoverTest.testFailoverMessageOnServer2(FailoverTest.java:1483)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at junit.textui.TestRunner.doRun(TestRunner.java:116)
at junit.textui.TestRunner.start(TestRunner.java:172)
at org.jboss.test.messaging.tools.junit.SelectiveTestRunner.main(SelectiveTestRunner.java:58)

1. Re: Non connected remoting clients throwing java.lang.Except

clebert.suconic Jan 18, 2007 5:00 PM (in response to clebert.suconic)

There is a remoting JIRA task for this:

http://jira.jboss.org/jira/browse/JBREM-657
Actions
2. Re: Non connected remoting clients throwing java.lang.Except

ron_sigal Jan 18, 2007 8:13 PM (in response to clebert.suconic)

I started working on http://jira.jboss.org/jira/browse/JBREM-657 yesterday. What I've been doing is adding a Client.quickDisconnect() and a Client.quickRemoveListener() that parallel Client.disconnect() and Client.removeListener() but don't attempt to communicate with the server. Of course, they should be used only when it is clear that there is a problem communicating with the server.

Does that work for Messaging?
Actions
3. Re: Non connected remoting clients throwing java.lang.Except

clebert.suconic Jan 18, 2007 8:35 PM (in response to clebert.suconic)

Yes... but what about this throw new Exception when a client is disconnected... and what situation the client gets disconnected on leasing?
Actions
4. Re: Non connected remoting clients throwing java.lang.Except

clebert.suconic Jan 18, 2007 8:42 PM (in response to clebert.suconic)

Ron... this is just personal preference...

but do you have a better name than quickRemove... quickWhatever?
Actions

5. Re: Non connected remoting clients throwing java.lang.Except

clebert.suconic Jan 19, 2007 12:48 PM (in response to clebert.suconic)

Another place where remoting is throwing java.lang.Exception:

java.lang.Exception: Error setting up client lease.
 at org.jboss.remoting.MicroRemoteClientInvoker.establishLease(MicroRemoteClientInvoker.java:388)
 at org.jboss.remoting.Client.setupClientLease(Client.java:521)
 at org.jboss.remoting.Client.connect(Client.java:430)
 at org.jboss.remoting.Client.connect(Client.java:420)
 at org.jboss.jms.client.remoting.JMSRemotingConnection.start(JMSRemotingConnection.java:99)
 at org.jboss.jms.client.delegate.ClientConnectionFactoryDelegate.invoke(ClientConnectionFactoryDelegate.java:200)
 at org.jboss.jms.client.delegate.ClientConnectionFactoryDelegate$createConnectionDelegate_4579211046834694258.invokeNext(ClientConnectionFactoryDelegate$createConnectionDelegate_4579211046834694258.java)
 at org.jboss.jms.client.container.StateCreationAspect.handleCreateConnectionDelegate(StateCreationAspect.java:86)
 at org.jboss.aop.advice.org.jboss.jms.client.container.StateCreationAspect0.invoke(StateCreationAspect0.java)
 at org.jboss.jms.client.delegate.ClientConnectionFactoryDelegate$createConnectionDelegate_4579211046834694258.invokeNext(ClientConnectionFactoryDelegate$createConnectionDelegate_4579211046834694258.java)
 at org.jboss.jms.client.container.ExceptionInterceptor.invoke(ExceptionInterceptor.java:71)
 at org.jboss.jms.client.delegate.ClientConnectionFactoryDelegate$createConnectionDelegate_4579211046834694258.invokeNext(ClientConnectionFactoryDelegate$createConnectionDelegate_4579211046834694258.java)

6. Re: Non connected remoting clients throwing java.lang.Except

clebert.suconic Jan 19, 2007 12:52 PM (in response to clebert.suconic)

"clebert.suconic@jboss.com" wrote:
Ron... this is just personal preference...

but do you have a better name than quickRemove... quickWhatever?

What about cancelConnection, cancelLease..... ???

Or...

clearConnection... clearLease...

The idea would be to disable the socket (or clearing it... cancelling it) without performing a server communication.

And... just to reinforce... can you guys remove those throw java.lang.Exception from the code?
Actions
7. Re: Non connected remoting clients throwing java.lang.Except

ovidiu.feodorov Jan 19, 2007 12:52 PM (in response to clebert.suconic)

Clebert: Please create a JIRA issue about this, schedule it with Beta2 and assign it to me, as I want to clear all Remoting issues by the end of this week.
Actions
8. Re: Non connected remoting clients throwing java.lang.Except

clebert.suconic Jan 19, 2007 1:29 PM (in response to clebert.suconic)

http://jira.jboss.org/jira/browse/JBMESSAGING-762
Actions
9. Re: Non connected remoting clients throwing java.lang.Except

ron_sigal Jan 19, 2007 8:07 PM (in response to clebert.suconic)

Hi Clebert,

I'm a little confused:

"clebert" wrote:

at least throw a meaninful Exception

"clebert" wrote:

can you guys remove those throw java.lang.Exception from the code?

If I understand, you want something like ClientDisconnectedException instead of a plain Exception? You're not saying we shouldn't throw an exception at all, right?

"clebert" wrote:

Ron... this is just personal preference...

but do you have a better name than quickRemove... quickWhatever?

disconnectALaGrandeVitesse()? :-)
Actions

10. Re: Non connected remoting clients throwing java.lang.Except

timfox Jan 20, 2007 2:13 PM (in response to clebert.suconic)

Hmmm, this:

Can not make remoting client invocation due to not being connected to server.
at org.jboss.remoting.Client.invoke(Client.java:639)
at org.jboss.remoting.Client.invoke(Client.java:627)
at org.jboss.jms.client.delegate.DelegateSupport.invoke(DelegateSupport.java:118)
at org.jboss.jms.client.delegate.ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.invokeNext(ClientSessionDelegate$createConsumerDelegate_N5002091796089334799.java)
at org.jboss.jms.client.container.StateCreationAspect.handleCreateConsumerDelegate(StateCreationAspect.java:153)
at org.jboss.aop.advice.org.jboss.jms.client.container.StateCreationAspect17.invoke(StateCreationAspect17.java)
at

Looks very much like another remoting bug I have replicated here:

http://jira.jboss.com/jira/browse/JBMESSAGING-765

I believe it is a bug in the way remoting handles reference counts for invokers.

11. Re: Non connected remoting clients throwing java.lang.Except

ovidiu.feodorov Jan 20, 2007 9:07 PM (in response to clebert.suconic)

"ron.sigal@jboss.com" wrote:
Hi Clebert,

I'm a little confused:

"clebert" wrote:

at least throw a meaninful Exception

"clebert" wrote:

can you guys remove those throw java.lang.Exception from the code?

If I understand, you want something like ClientDisconnectedException instead of a plain Exception? You're not saying we shouldn't throw an exception at all, right?

This will clear any confusion: http://jira.jboss.org/jira/browse/JBREM-680
Actions
12. Re: Non connected remoting clients throwing java.lang.Except

ovidiu.feodorov Jan 20, 2007 9:19 PM (in response to clebert.suconic)

We'll use remoting's CannotConnectException. According their documentation: "Clustering layers can rely this exception to failover."
Actions

Go to original post