Backport to 1_0_1_SP1 has broken the test suite

[timfox]

Naming no names, but the person who backported http://jira.jboss.com/jira/browse/JBMESSAGING-791 (duplicate client ids) to the 1_0_1_SP obviously didn't run the test suite since the fix has broken several other tests.

Please, lets remember to run the test suite before committing. There's no excuses on the 1_0 branches it only takes 47 minutes to run the whole thing.

:)

[timfox]

Ok I have fixed the tests in 1_0_1_SP (one was also failing in TRUNK because of this).

Also the fix itself was incomplete - the client ID was only being checked when set programmatically but client ids can also be set via a connection factory or when preconfigured in the database.

[ovidiu.feodorov]

Yeah, I ported it.

And I checked that in, fully assured that cruisecontrol will do its job.

But wait, we don't have cruisecontrol running on 1_0_1_SP! Ooops.

However, willl we release SP4 without a full testsuite? No.

Relax, guys, the system works.

[timfox]

Stop making fucking excuses and remember to run the test suite before committing. ;)

That is the system.

[ovidiu.feodorov]

Ummmm, should I kindly remind you this is a public forum? :)

[timfox]

ROFL