Failure on RemotingConnectionConfigurationTest::testConnecti

[clebert.suconic]

After updating Remoting, this test is failling...

The test is calling callbackConnectors.get(callbackHandler) and this HashMap operation is retuning a HashSet while it used to return a Connector.

 Connector connector = Connector)callbackConnectors.get(callbackHandler);

I don't know if the API changed... if this test is now invalid... or what?

I would need to get some input on this... as i didn't authored the test I don't know what's this is supposed to return.

Ron, Tom Elrod?



This is a more complete snippet of the failing test:

if ("socket".equals(transport)
 || "sslsocket".equals(transport)
 || "bisocket".equals(transport)
 || "sslbisocket".equals(transport))
 {
 field = Client.class.getDeclaredField("callbackConnectors");
 field.setAccessible(true);
 Map callbackConnectors = (Map)field.get(client);

 InvokerCallbackHandler callbackHandler = remotingConnection.getCallbackManager();
 Connector connector = (Connector)callbackConnectors.get(callbackHandler);
 locator = new InvokerLocator(connector.getInvokerLocator());
 assertEquals(address, locator.getHost());
 assertEquals(freePort, locator.getPort());
 }

[ron_sigal]

Ah, the dangers of reflection.

In the course of working on JBREM-727 ("Make Client's implicitly created Connectors accessible") I changed the field Client.callbackConnectors to map from an InvokerCallbackHandler to the *set* of all the Connectors with which it is registered. Since Messaging's JMSRemotingConnection always creates a new InvokerCallbackHandler (CallbackManager, in particular) for each connection, callbackConnectors should map each CallbackManager to a singleton set. I.e.,

Connector connector = (Connector)callbackConnectors.get(callbackHandler);

should be

Connector connector = (Connector)callbackConnectors.get(callbackHandler).iterator().next();

[clebert.suconic]

Thanks... it fixed the testcase.