XATestBase::testRecoverOnXA

[clebert.suconic]

When calling session.recover, the message was being ACKed only when session.close was called.

Even when you don't have anything to recover, SessionAspect::handleRecover was setting recoverCalled to true, and handlePostDeliver wouldn't be able to ACK anything.

This would be okay if the client aways called session.close afterward... but for instance when using JCA the session is never closed (well.. at least for the life cycle of a testcase).

So.. I'm now only setting recoverCalled if there is anything to be recovered, so this would be okay.

I have added XATestBase::testRecoverOnXA with an expected behavior. We could change this anyway we want as long this test works.

[timfox]

Is there a JIRA task?

Has it been ported to 1.0.1.SP5?

[timfox]

http://jira.jboss.com/jira/browse/JBMESSAGING-950

[timfox]

Clebert - can you explain the problem here more clearly and in more detail?

I don't really understand what you are trying to say.

[timfox]

When calling session.recover, the message was being ACKed only when session.close was called.

If this is true, then it is a bug.

[clebert.suconic]

"timfox" wrote:
Is there a JIRA task?

Has it been ported to 1.0.1.SP5?

I was doing this as part of http://jira.jboss.org/jira/browse/JBMESSAGING-946

I haven't ported it, and I don't know if this affects 1.0.1.SP yet. We would need to port textRecoverOnXA to the branch and verify.

[clebert.suconic]

I haven't ported it, and I don't know if this affects 1.0.1.SP yet. We would need to port textRecoverOnXA to the branch and verify.

It does affect 1.0.1.SP.

If you call recover in a session (nonTransacted, AutoACK), the ACK is only sent when you call session.close(). (You don't even need XA to have this happening)