How to get to a destination given a Delivery?

[sergeypk]

Hi,

I'm working on http://jira.jboss.com/jira/browse/JBMESSAGING-938, implementing MaxDeliveryAttempts for destinations. I need to change ServerSessionEndpoint.cancelDeliveryInternal to take the destination's max delivery attempts into account, but I see no way to get to the destination given only a Delivery or Cancel object.

I noticed that destinations are implemented as DeliveryObservers attached to a particular delivery. Should DeliveryObserver interface be enhanced to include getMaxDeliveryAttempts() method or maybe shouldCancel(int deliveryCount)? Or is there another way?

Sergey

[timfox]

It's easier than that.

You just need to pass the maxDeliveryAttempts value into the constructor of the ServerConsumerEndpoint, in the method ServerSessionEndpoint::createConsumerDelegateInternal.

Take a look at how this is already done for expiryQueue or dlq which also has a local override that takes precendence over the server peer value.

Then you just need to remove the maxDeliveryAttempts attribute from the session and make sure you pass the correct value into ServerSessionEndpoint methods when called from ServerConsumerEndpoint

[timfox]

You'll need to add a maxDeliveryAttempts attribute to DeliveryRecord too, like is done with dlq, expiryQueue etc

[timfox]

Sergey-

I saw your commit.

Looks fine, but a couple of points:

a) Can you update the documentation

b) MaxDeliveryAttemptsTest probably belongs in DLQTest

c) In MaxDeliveryAttempts I can't see any test that verifies if MaxDeliveryAttempts is set to -1 then the value from the server peer is used.

[sergeypk]

a) and c) Will do.

b) I originally put the test into DLQTest but then decided to make a separate one because it looked out of place to me. Should I combine them nevertheless?

[timfox]

I think they should be combined.

After all, DLQTest currently has all the other tests related to maxDeliveryAttempts