[thomasra]

I came to the same conclusion after looking at the activemq code.

The pun was intended, Tim. ;)

I'll see if there are any bugs registered in activemq for this issue...

The original suggestion still stands, though, regarding remote reply functionality.

[timfox]

"thomasra" wrote:

The pun was intended, Tim. ;)

NP, don't worry I am always grumpy when I first wake ;)

I have added a task

http://jira.jboss.com/jira/browse/JBMESSAGING-988

[timfox]

"timfox" wrote:
[
I have added a task

http://jira.jboss.com/jira/browse/JBMESSAGING-988

Thomas, if you want, you could complete this task and contribute it? (hint, hint) ;)

[thomasra]

...and yes, removing the destination check allows the message to be sent.

[thomasra]

I commented the JIRA issue.

[sergeypk]

Actually, the JMS spec says JMSDestination is supposed to be ignored when a message is sent, the producer's destination must be used instead, and the message's JMSDestination must be overwritten with the real destination afterwards. So I think that even checking in ProducerAspect shouldn't be done.

The spec is a bit unclear since it also says that InvalidDestinationException "must be thrown when a destination is not understood by the provider". I'd take that to mean "the destination passed to createProducer/createConsumer".

Also, the code currently requires JMSReplyTo to be a JBossDestination as well, I don't know if this restriction is necessary.

[thomasra]

"sergeypk" wrote:
Actually, the JMS spec says JMSDestination is supposed to be ignored when a message is sent, the producer's destination must be used instead, and the message's JMSDestination must be overwritten with the real destination afterwards. So I think that even checking in ProducerAspect shouldn't be done.

I agree with this - this is the responsibility of the "other side" in order to be compliant - they should overwrite it with the correct destination from the producer.

However, the JMSReplyTo bit is more difficult. Like JMSDestination, it doesn't apply across providers, but AFAIK there is no API available to set this on producer, which means it cannot be JBM-specific if we want to support this. Though the most likely case is using Queue/TopicRequestor, which pretty much hides all this for the client anyway. I think temp destinations are the only way to get remote replyto to work correctly.

[timfox]

Just to clarify things here:

The change Sergey is making is not because we are not compliant.

In an ideal world ActiveMQ would fix their stuff, but I am not holding my breath.

The reason for this task is to allow us to work with ActiveMQ without having to wait for them to fix their code.

Hope that is clearer.

[sergeypk]

ActiveMQ has already fixed it, according to http://issues.apache.org/activemq/browse/AMQ-1232

I think I was misunderstood - I think we shouldn't do any checks on the value passed to setJMSDestination - neither in setJMSDestination, nor in ProducerAspect. It's simply not necessary (as far as I can tell), the spec even says we must ignore the value completely.

My question was whether we should also skip all checks on JMSReplyTo - e.g. to allow sending a JBossMessage with JMSReplyTo set to an ActiveMQ destination.

[timfox]

Yes, the point of this task is to remove those checks.

[thomasra]

Yes, like I said: it is the "other" side that is responsible for overwriting with a correct JMSDestination. BUT, in order to support something like the topic says (remote replyto) we would have to do something about the JMSReplyTo value (JBM-specific or not).

[timfox]

http://jira.jboss.com/jira/browse/JBMESSAGING-1007

[mnop629]

For the Bridging from JBM to ACtiveMQ, I saw there is a bounded property "outbound" in ds.xml. Is there any other way to bound the physical queue destination name like below:

queue/qTempBridge

It wouldn't able to resolve in JBM, it said naming not found XXXX..

[mnop629]

"mnop629" wrote:
For the Bridging from JBM to ACtiveMQ, I saw there is a bounded property "outbound" in ds.xml. Is there any other way to bound the physical queue destination name like below:

"<attribute name="TargetDestinationLookup">queue/qTempBridge"</attribute>"

It wouldn't able to resolve in JBM, it said naming not found XXXX..

[mnop629]

For the Bridging from JBM to ACtiveMQ, I saw there is a bounded property "outbound" in ds.xml. Is there any other way to bound the physical queue destination name like below:

queue/qTempBridge

It wouldn't able to resolve in JBM, it said naming not found XXXX..