Getting a list of all ClientConsumers (http://jira.jboss.com

[sergeypk]

I don't see an easy way to get a list of all ClientConsumers associated with a particular Connection, what would be the best way to collect them?

Can I use HierarchicalState.getChildren() to get a list of SessionStates from ConnectionState, and then use getChildren() again to get the ConsumerStates? I don't see getChildren() used in this manner anywhere in the code so I wonder if it's the right way to go.

[sergeypk]

The issue got truncated, it's http://jira.jboss.com/jira/browse/JBMESSAGING-983

[timfox]

Yes that should work.

For this task, you want to consider adding a start() and stop() method on the ClientConsumer class.

First you need to tell the server consumer endpoint to stop and obtain the lastDeliveryID (like how is currently done in closing()).

Then wait for the delivery to arrive and wait for onMessages to execute, much as is currently done in close().

[sergeypk]

I have got it working locally but I will need to add some more tests to make sure it's implemented correctly. I had to collect all those lastDeliveryIDs into a map on the server side and send them back to the client in a ConnectionStopResponse packet that I created.

Do we really have to wait for the delivery lastDeliveryID to come in this case? Wouldn't it be possible for ClientConsumer to still accept messages as usual when stopped but not deliver them to receive() and onMessage()? Then Connection.stop() could tell the server side to stop, wait until every ClientConsumer finishes any onMessage calls it has already started and return afterwards?

[timfox]

Yes you're right.

There's no need to wait for the deliveries to arrive, just need to wait for onmessages to complete and make sure no more messages are returned to receive or sent to onMessage until it is restarted.