ManagedObject support in next messaging release

[starksm64]

ManagedObject support in next messaging release
One of the issues I have linked to the http://jira.jboss.com/jira/browse/JBAS-4689 1.4.0.GA task is the need for managed object annotations to properly identify the jms destination types. Currently the org.jboss.jms.server.destination.QueueService/TopicService components are coming from the jms release. These need mc management annotations to describe the management interface for jbossas5. For 1.4.0.GA to be usable in jbossas5/4.x, a separate integration layer is needed to isolate the jbossas specific dependencies.

JBMESSAGING-1065 was raised as a blocking task for the JBAS integration.

[clebert.suconic]

> or 1.4.0.GA to be usable in jbossas5/4.x, a separate integration layer is needed to isolate the jbossas specific dependencies

Shouldn't this integration with MC exist on jbossas/trunk? on that case there is no need to hold the 1.4.0.GA release?

JBossMessaging, as you said, could be both used by JBAS 4 and JBAS 5... so we can't implement those MC interfaces directly, right?

anyway... do you have any other service as an example with what needs to be done?

[starksm64]

Yes, I would say it should be in AS or an AS specific codebase outside of the jms core.

You simply need to annotate the service mbean code class, an example of which is here:
http://wiki.jboss.org/wiki/Wiki.jsp?page=ManagedObjects in the "Annotating a Service MBean Class" section.

import org.jboss.managed.api.ManagedOperation.Impact;
import org.jboss.managed.api.annotation.ManagementObject;
import org.jboss.managed.api.annotation.ManagementObjectID;
import org.jboss.managed.api.annotation.ManagementOperation;
import org.jboss.managed.api.annotation.ManagementParameter;
import org.jboss.managed.api.annotation.ManagementProperties;
import org.jboss.managed.api.annotation.ManagementProperty;
import org.jboss.managed.api.annotation.ViewUse;

@ManagementObject(componentType=@ManagementComponent(type="JMSDestination",subtype="Queue"), properties=ManagementProperties.EXPLICIT)
class QueueService
{
// Add ManagementProperty, ManagementOperation annotations
}

[timfox]

Ok if this is just adding an annotation it should be easy.

BTW lucky we decided to move to Java5 with JBM, otherwise I don't know how we would have done this.

[alesj]

"timfox" wrote:

BTW lucky we decided to move to Java5 with JBM, otherwise I don't know how we would have done this.

MC has annotations per instance via XML.
So no luck included here. ;-)

[clebert.suconic]

"alesj" wrote:

MC has annotations per instance via XML.
So no luck included here. ;-)

That would be a good option for us, so we wouldn't need to add any JBoss5 specific annotations on our code, as our code is also intended to run on JBoss4.

but i can't find any documentation on how to do it.

[clebert.suconic]

"alesj" wrote:

MC has annotations per instance via XML.
So no luck included here. ;-)

That would be a good option for us, so we wouldn't need to add any JBoss5 specific annotations on our code, as our code is also intended to run on JBoss4.

but i can't find any documentation on how to do it.

I just confirmed that this doesn't exist yet...

I will just add the annotations to org.jboss.mq.server.jmx.Queue and Topic...

So the annotation will sit in an integration layer:

http://anonsvn.jboss.org/repos/jbossas/trunk/messaging/src/main/org/jboss/mq/server/jmx/Queue.java

http://anonsvn.jboss.org/repos/jbossas/trunk/messaging/src/main/org/jboss/mq/server/jmx/Topic.java

[starksm64]

That means that the messaging destinations need to use these mbeans. Currently that is not the case:

[starksm@succubus testsuite]$ cat ../build/output/jboss-5.0.0.Beta3/server/default/deploy/messaging/destinations-service.xml
<?xml version="1.0" encoding="UTF-8"?>

<!--
 Messaging Destinations deployment descriptor.

 $Id: destinations-service.xml 64130 2007-07-18 23:21:27Z [e-mail] $
 -->

<server>

 <!--
 The Default Dead Letter Queue. This destination is a dependency of an EJB MDB container.
 -->

 <mbean code="org.jboss.jms.server.destination.QueueService"
 name="jboss.messaging.destination:service=Queue,name=DLQ"
 xmbean-dd="xmdesc/Queue-xmbean.xml">
 <depends optional-attribute-name="ServerPeer">jboss.messaging:service=ServerPeer</depends>
 <depends>jboss.messaging:service=PostOffice</depends>
 </mbean>

 <!--
 The Default Expiry Queue.
 -->

 <mbean code="org.jboss.jms.server.destination.QueueService"
 name="jboss.messaging.destination:service=Queue,name=ExpiryQueue"
 xmbean-dd="xmdesc/Queue-xmbean.xml">
 <depends optional-attribute-name="ServerPeer">jboss.messaging:service=ServerPeer</depends>
 <depends>jboss.messaging:service=PostOffice</depends>
 </mbean>

</server>

[timfox]

That means that the messaging destinations need to use these mbeans. Currently that is not the case:

Right, I'd rather not force people to change their configs - this could be a real hassle.

I'd rather just add the annotations to the current classes and live with the necessary imports.

When we do the full MC integration as part of JBM 2.0 (i.e. POJOify everything) then we'll be changing everything around anyway and this will result in config changes. We could create the proper integration layer at that stage.

[clebert.suconic]

I'd rather just add the annotations to the current classes and live with the necessary imports.

This would force us to add jboss-managed.jar (from jboss-5) into jboss4/lib when installing jboss-messaging.

If there is no issue on adding that jar, I would prefer doing it this way also.

(Actually Scott, why don't you see if we could have jboss-managed.jar officially distributed as part of jboss-4. This way annotated services would be able to be deployed on both servers).

[timfox]

Can't we just annotate via xml as Ales mentioned?

That would make life a whole lot easier

[starksm64]

Here is another approach that also moves toward having the annotations in the xml config. We do have some annotation support in the service mbean descriptors, for example:

<mbean name="jboss.test:type=BasicMBeanName" code="BasicMBeanCode">
 <annotation>@org.jboss.test.system.metadata.annotation.CompType(type="DS",subtype="LocalTX")</annotation>
</mbean>

so I can add a ManagedCode annotation that allows you to specify the class to scan for the management annotations. You can then add empty subclasses of the jms destination mbeans in the server/messaging project and then specify the management annotations on those, and point to those classes using the annotation element. Perhaps this can reuse the legacy mbeans Clebert updated. I have reopened JBAS-4658 for this.

[starksm64]

"timfox" wrote:
Can't we just annotate via xml as Ales mentioned?

That would make life a whole lot easier

Possibly, if you change from -service.xml to -beans.xml for the destinations.

[anil.saldhana]

Just like EJB3, Web Services , why cannot messaging have the integration code base in the AS workspace?

This really is a critical task which has been raised since few months now.

[dimitris]

In my local workspace I can add an annotation in the mc/managed api like:

package org.jboss.managed.api.annotation;
...
@Target({ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
public @interface ManagementObjectClass
{
 /** The class annotated with ManagementObject */
 Class code();
}

Then update the mc/org.jboss.managed.plugins.factory.AbstractManagedObjectFactory to handle the indirection from the ManagementObjectClass annotation to the real ManagedObject one.

Will this be picked up whoever calls the ServiceMetaDataICF.getManagedObjectClass(ServiceMetadata md) method?

If yes, no change would be need there.

Or have I missunderstood what you want?