4 Replies Latest reply on Jul 7, 2008 4:41 PM by clebert.suconic

    Moving slow tests out into timing

    timfox

      As discussed at the F2F can everyone start moving their slow tests out into the timing area.

      org.jboss.messaging.tests.timing.

      We should aim to get a unit test run < 30 seconds.

      Any tests (e.g. journal tests -clebert) which do nothing apart from measure performance belong neither in the unit test suite nor the timing suite.

      The ant script will need to be updated to exclude timing and concurrent tests.

        • 1. Re: Moving slow tests out into timing
          ataylor

          The unit tests are now running under a minute on my box. about 40 seconds of this however is because of the package org.jboss.messaging.tests.unit.core.journal.impl. These tests are integration tests and still need moving and we also still need to write some proper unit tests for the journal stuff.

          • 2. Re: Moving slow tests out into timing
            timfox

             

            "ataylor" wrote:
            The unit tests are now running under a minute on my box. about 40 seconds of this however is because of the package org.jboss.messaging.tests.unit.core.journal.impl. These tests are integration tests and still need moving and we also still need to write some proper unit tests for the journal stuff.


            Right. Clebert should be on the case with this when he wakes :)

            • 3. Re: Moving slow tests out into timing
              clebert.suconic

              Now the entire unit-tests runs is less than 10 seconds.

              • 4. Re: Moving slow tests out into timing
                clebert.suconic

                 

                "timfox" wrote:

                Any tests (e.g. journal tests -clebert) which do nothing apart from measure performance belong neither in the unit test suite nor the timing suite.


                I have moved those tests into performance a long time ago.

                There are though few timing tests, that are creating too many records and they could be simplified.

                Some of those tests were moved to performance when they should be actually be moved to timing. I'm moving them now.