Annoyance when running unit tests in eclipse

[timfox]

Both Clebert and I are getting

log4j error: setFile(null,true) call failed.
java.io.FileNotFoundException: /logs/messaging-.log (No such file or directory)
 at java.io.FileOutputStream.openAppend(Native Method)
 at java.io.FileOutputStream.<init>(FileOutputStream.java:177)
 at java.io.FileOutputStream.<init>(FileOutputStream.java:102)
 at org.apache.log4j.FileAppender.setFile(FileAppender.java:289)
 at org.apache.log4j.FileAppender.activateOptions(FileAppender.java:163)
 at org.apache.log4j.DailyRollingFileAppender.activateOptions(DailyRollingFileAppender.java:215)
 at org.apache.log4j.config.PropertySetter.activate(PropertySetter.java:256)
 at org.apache.log4j.xml.DOMConfigurator.parseAppender(DOMConfigurator.java:220)
 at org.apache.log4j.xml.DOMConfigurator.findAppenderByName(DOMConfigurator.java:150)
 at org.apache.log4j.xml.DOMConfigurator.findAppenderByReference(DOMConfigurator.java:163)
 at org.apache.log4j.xml.DOMConfigurator.parseChildrenOfLoggerElement(DOMConfigurator.java:425)
 at org.apache.log4j.xml.DOMConfigurator.parseRoot(DOMConfigurator.java:394)
 at org.apache.log4j.xm

When running unit tests in eclipse.

Clebert suggests this is due to some change made by Andy recently in log4j.xml.

Any ideas?

[ataylor]

The test log4j.xml confog files output the logs to the following directory, '${module.output}/logs/messaging-${test.logfile.suffix}.log', the module.output is a system property set in the ant target, so you can set this in you're eclipse test config. Alternatively do what i do and have a generic IDE log4j.xml file that i use in all my projects.

[timfox]

Can't we have it so it works out of the box without having to set system properties like it used to?

[ataylor]

This is how it used to! I just copied what was already there.

I can change it so it uses a local directory if you want, i.e. ./logs/...

[timfox]

"ataylor" wrote:
This is how it used to! I just copied what was already there.

Well... we never used to get those exceptions so something has changed.

[ataylor]

Ok, Ive fixed it. tests/config was ahead of src/config in the classpath. When i added the log4j file to tests/config it was picked up first. Ive switched these around.

Ive installed an eclipse plugin for intellij so from now on i'll use the same classpath as you eclipse users

[timfox]

I'm confused.

I seem to have one log file in tests/output/logs, another one in tests/build/logs neither of which are the output of the unit tests when run in eclipse.

Can't we just have one config and one log file for eclipse.

Also, I thought we got rid of the convention of using output dirs, and use build everywhere??

[timfox]

"ataylor" wrote:
Ok, Ive fixed it. tests/config was ahead of src/config in the classpath. When i added the log4j file to tests/config it was picked up first. Ive switched these around.

But these are tests. Surely they should be using log4j.xml from tests/config *not* src/config!!

[timfox]

Seems like this whole test logging thing is a complete mess.. Needs a cleanup.

[timfox]

Ok. so I worked out where logs from running tests in eclipse goes - it uses the main log4g config from src/config so the logs go in trunk/logs.

This is all back to front and upside down.

We should have:

1 main log4j config file which lives in src/config this is used for server logging, not for tests.

1 log4j config file in tests/config - this is used for tests and nothing else. "Tests" include:
a) Tests run in eclipse
b) Tests run using runtest on the command line
c) Tests run using ant from command line (normal test suite)

For consistency test log4j output should go to tests/logs, not tests/output/logs or tests/build/logs or anywhere else.

[ataylor]

Ok, let me tidy all this up

[ataylor]

ok, this should work for all test run scenarios now. log written to ./tests/logs

[timfox]

It's still not working,

When I run a test in eclipse, it outputs to tests/logs ok. But the log file appends (which is annoying in itself).

I edited tests/config/log4j.xml to change append to false, but it makes no difference, i then changed the name of the output file name in tests/config/log4j.xml but that makes no difference either,

${deity of choice} only knows where it's getting log4j.xml from......... sigh

[timfox]

This was due to eclipse caching the real log4j in a private folder :(