-
15. Re: creating integration layer
ataylor Nov 12, 2008 7:58 AM (in response to ataylor)Quick question - do we still need to drag in all the dependencies in build-thirdparty.xml?
thats something i was going to do. I need to go through each dependency and find out where its needed. I think theres still a few we might be able to remove. Also I might update some of the libraries from beta etc to GA.. -
16. Re: creating integration layer
ataylor Nov 12, 2008 3:07 PM (in response to ataylor)ive sorted through all the dependencies, if you look at build-thirdparty, i've commented on whats needed for what. Ive also removed whats not currently needed.
-
17. Re: creating integration layer
timfox Nov 12, 2008 3:48 PM (in response to ataylor)Looks good, although I can't say I understand why we need the following to run the unit tests:
<componentref name="trove" version="1.0.2-brew"/> <componentref name="jboss/common-core" version="2.2.2.GA"/> <componentref name="jboss/aop" version="2.0.0.beta2"/> <componentref name="javassist" version="3.6.0.GA/"/> <componentref name="jboss/jbossxb" version="2.0.0.CR4"/> <componentref name="apache-xerces" version="2.7.1-brew"/> <componentref name="jboss/profiler/jvmti" version="1.0.0.CR5-brew"/> <componentref name="slf4j/log4j" version="1.4.3"/>
-
18. Re: creating integration layer
ataylor Nov 13, 2008 4:22 AM (in response to ataylor)Looks good, although I can't say I understand why we need the following to run the unit tests:
currently the integration, unit and stress tests all share the same classpath. I think i'll change this so that they each have their own. Any unit tests that need a classpath should probably be integration tests any way. -
19. Re: creating integration layer
clebert.suconic Nov 13, 2008 2:00 PM (in response to ataylor)Right now the JMS test is failing, as it is depending on test.util from unit-tests.
do this, and you will see what I mean:ant clean ant jms-tests
The build on hudson is also failing because of that.
You would need to add a dependency on the unit-test compilation, and add test.classes.dir on jms.test.compilation.classpath, or find a better way to solve that dependency. -
20. Re: creating integration layer
timfox Nov 13, 2008 2:04 PM (in response to ataylor)Jeff was supposed to have fixed this...
Can you just delete the test for now, so we can get the build working again?
Everyone - please always run tests locally before committing to prevent things like this. -
21. Re: creating integration layer
timfox Nov 13, 2008 2:27 PM (in response to ataylor)Ok, I deleted it
-
22. Re: creating integration layer
clebert.suconic Nov 13, 2008 2:31 PM (in response to ataylor)"timfox" wrote:
Everyone - please always run tests locally before committing to prevent things like this.
I "believe" that test would work if you didn't clean your build before running it.
So.. maybe you should not only run tests locally, but also clean your workspace before running it. -
23. Re: creating integration layer
jmesnil Nov 14, 2008 8:35 AM (in response to ataylor)i've readded the broken integration test correctly this time.
sorry guys...
As an aside, the integration tests runs fairly quickly except for the XXRandomFailoverTest which takes 75% of the time (16 min on a 22 min run)
Given their random natures, couldn't we move them to their own Ant targets and let Hudson deals with these tests?
wdyt?