Can it be a final static?

[gaohoward]

This class only has one static member

public class JMSClientVMIdentifier
{
 public static String instance = GUIDGenerator.generateGUID();
}

I think it should be final like

public class JMSClientVMIdentifier
{
 public static String instance = GUIDGenerator.generateGUID();
}

[gaohoward]

Sorry, should be

public class JMSClientVMIdentifier
{
 public static final String instance = GUIDGenerator.generateGUID();
}

[timfox]

It help us if you explain why you think it should be changed thus.

[gaohoward]

This static is used to identify a JBM process, not only client processes use it, but also the Postoffice use it. So once it is initialized it should never be changed as long as the process is alive. So make it final would be more proper. It will forbid any attempt to change it.

[timfox]

"gaohoward" wrote:
This static is used to identify a JBM process, not only client processes use it, but also the Postoffice use it. So once it is initialized it should never be changed as long as the process is alive. So make it final would be more proper. It will forbid any attempt to change it.

Ok sure, but it's not a big deal - nothing does change it.