JMSTests are broken...

[clebert.suconic]

Jeff... just to let you know.. JMSTests are broken.


I believe you would be able to fix it real quick... as you know what you have changed on the XML schemas.

[clebert.suconic]

jmesnil: Never mind... I thought it was something complex, when it was actually this :-)


http://fisheye.jboss.org/browse/Messaging/trunk/src/config/jbm-configuration.xml?r1=5684&r2=5689

[jmesnil]

thanks clebert, i've removed the property from the configuration file.
It was not meant to be committed...

[clebert.suconic]

I was thinking... you should maybe leave it commented there. (Without your IP of course).


That was probably the piece missing for accessing JBM remotely. I've tried some time ago and it didn't work.

[clebert.suconic]

JMSTests are broken again...

[timfox]

Curiously they pass when run in eclipse, but fail on the command line:

 [junit] *** DEPLOYMENTS MISSING DEPENDENCIES: Name -> Dependency{Required State:Actual State}
 [junit] QueueDeployer -> DeploymentManager{Instantiated:** NOT FOUND **}, Configuration{Instantiated:Installed}
 [junit]
 [junit] at org.jboss.kernel.plugins.deployment.AbstractKernelDeployer.internalValidate(AbstractKernelDeployer.java:260)
 [junit] at org.jboss.kernel.plugins.deployment.AbstractKernelDeployer.validate(AbstractKernelDeployer.java:174)
 [junit] at org.jboss.messaging.integration.bootstrap.JBMBootstrapServer.bootstrap(JBMBootstrapServer.java:115)
 [junit] at org.jboss.kernel.plugins.bootstrap.AbstractBootstrap.run(AbstractBootstrap.java:89)
 [junit] at org.jboss.messaging.integration.bootstrap.JBMBootstrapServer.run(JBMBootstrapServer.java:80)
 [junit] at org.jboss.test.messaging.tools.container.LocalTestServer.start(LocalTestServer.java:162)
 [junit] at org.jboss.test.messaging.JBMServerTestCase.setUp(JBMServerTestCase.java:152)
 [junit] at org.jboss.test.messaging.jms.JMSTestCase.setUp(JMSTestCase.java:43)
 [junit] at junit.framework.TestCase.runBare(TestCase.java:128)
 [junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
 [junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
 [junit] at junit.framework.TestResult.run(TestResult.java:109)
 [junit] at junit.framework.TestCase.run(TestCase.java:120)
 [junit] at junit.framework.TestSuite.runTest(TestSuite.java:230)
 [junit] at junit.framework.TestSuite.run(TestSuite.java:225)
 [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:421)
 [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:912)
 [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:743)

So probably some classpath issue.

[timfox]

The regression was introduced in revision 5706:

Author: jmesnil
Date: 2009-01-23 11:40:06 -0500 (Fri, 23 Jan 2009)
New Revision: 5706

Modified:
 trunk/src/config/jbm-jboss-beans.xml
Log:
JBMESSAGING-1301: Provide xml schemas for our xml config

* added QueueDeployer to JBoss beans


Modified: trunk/src/config/jbm-jboss-beans.xml
===================================================================
--- trunk/src/config/jbm-jboss-beans.xml 2009-01-23 16:23:30 UTC (rev 5705)
+++ trunk/src/config/jbm-jboss-beans.xml 2009-01-23 16:40:06 UTC (rev 5706)
@@ -112,6 +112,17 @@
 </parameter>
 </constructor>
 </bean>
+
+ <bean name="QueueDeployer" class="org.jboss.messaging.core.deployers.impl.QueueDeployer">
+ <constructor>
+ <parameter>
+ <inject bean="DeploymentManager"/>
+ </parameter>
+ <parameter>
+ <inject bean="Configuration"/>
+ </parameter>
+ </constructor>
+ </bean>

 <bean name="SecurityDeployer" class="org.jboss.messaging.core.deployers.impl.SecurityDeployer">
 <constructor>

I will revert for now, until Jeff can fix it properly

[timfox]

We should all make sure we run the tests before committing.

[clebert.suconic]

"timfox" wrote:
We should all make sure we run the tests before committing.

That's come to a question: What's the minimal test everybody is running before commit?

all-tests also include "stress-tests"

integration-tests is not enough.

I have been using hudson-tests.

I would suggest we rename hudson-tests to something different, and we all use the same target.