security and createQueue

[ataylor]

As part of https://jira.jboss.org/jira/browse/JBMESSAGING-1535 I'm making the security finer grained. Locallly so far i have:

SEND
CONSUME
MANAGE
CREATE_DURABLE_QUEUE
DELETE_DURABLE_QUEUE
CREATE_TEMP_QUEUE
DELETE_TEMP_QUEUE

with regard to the last 4 the problem is it doesn't cover all areas, since the queue being created may be non temporary and non durable.

Another right 'createQueue' would fix this but the that implies that if someone had createQueue privileges then by default they have createTempQueue and createDurableQueue privileges which may not be the case.

Or we could allow anyone to create non durable non temp queues.

wdyt?

[jmesnil]

I'm not in favor of allowing anyone to create non durable non temp queue: I prefer to grant permissions explicitly rather than implicetly.
I'm also not in favor to add permissions for all the combination of (non)durable & non(temp)

Dumb question: do we really need to distinguish between non durable and durable queue wrt to permissions?
Can't we simply have 4 permissions:
CREATE_QUEUE
DELETE_QUEUE
CREATE_TEMP_QUEUE
DELETE_TEMP_QUEUE

where CREATE_QUEUE & DELETE_QUEUE are checked wether the queue is durable or not?

wdyt?

[timfox]

We need to distinguish between durable and non durable permissions.

However I'm not sure we need to distinguish on temporary.

[ataylor]

Ok, I'll add create/deletenondurablequeue and remove temp