Configuration files on Management tests..

[clebert.suconic]

There were a few tests failing on Management (what was also causing a cascade failure because of server not being stopped).

The deployers were not finding jms-users and jbm-configuration on that test. Because of that the test would always pass on Eclipse and always fail thorugh hudson or ant.

Because of that I added those files at ./tests/config.. but I'm not sure if the test was supposed to use those files or not. Jeff would probably know better as he's the author of the test.


After I added those two files I could get a green testsuite on my box.

[clebert.suconic]

BTW: This config thing on the testsuite needs to be better fixed. I don' t know how to do it ATM.

If I added jbm-configuration.xml into /tests/config, ExpiryMessageQueue is leaving messages on expiryQueue. By consequence the assertion on JMSTest will not work and subsequent tests will fail.

jms.LargeMessageTest failed on hudson now because of this (http://hudson.qa.jboss.com/hudson/view/JBM%202/job/JBM2-tests/5165/testReport/)

I changed ExpiredMessageTest super class, so at least it would show the failure on the right place.

I could then fix ExpiryMessageueue, by removing the ExpiryQueue from jbm-configuration, but I got other tests failing for a reason I couldn' t understand yet.


Anyway.. .that' s the reason behind those failures.. but I would need to talk to you guys before being able to fix it, and it is kind of late of night for that now.


Talk to you guys later


Clebert

[clebert.suconic]

I could then fix ExpiryMessageueue, by removing the ExpiryQueue from jbm-configuration, but I got other tests failing for a reason I couldn' t understand yet.

I didn' t commit this change BTW.

But the test will be fixed if you remove the expiry-address on ./tests/config/jbm-configuration.xml (the one I added to fix management).

But other tests will fail.. that' s why I say this needs to be improved somehow.

[timfox]

I guess there must be some classpath issue. Those files are already in src/config/stand-alone/non-clustered which should be on the classpath.

[timfox]

But the tests shouldn't be using those files anyway.. I'm confused

[timfox]

I've fixed this.

The problem was that src/config/stand-alone/non-clustered was on the eclipse classpath, but not on the classpath when running tests via the script.

It actually shouldn't be on the classpath, so I removed it. I then just disabled security in the start stop tests so they don't nee any jbm-users.xml file.

I also removed the files you added.

BTW, I also have to increase default max AIO to 1000, since it was intermittently failing on my box due to run out of AIO.

[clebert.suconic]

BTW, I also have to increase default max AIO to 1000, since it was intermittently failing on my box due to run out of AIO.

You run out of AIO when you have MAX_AIO_SIZE * NumberOfOpenedFiles > 64k (The max-aio configured at OS level).


so.. increasing the default MAX_AIO_SIZE will get you to have a lower number of files.. not the opposite.


When you have more writes than max-aio, they will just wait on the executor until the queue is freed up. So I don't think that would be your case.


BTW: Better thinking now.. I think I should rename that parameter to something else such as AIO_QUEUE_SIZE.

[timfox]

Ok, I'll put it back to 500 then ;)