JBAS-4193, xml validation, empty application.xml

[aloubyansky]

I've been looking into the https://jira.jboss.org/jira/browse/JBAS-4193

To make it work, the following should be uncommented for the following two deployers

<bean name="EARStructureDeployer" class="org.jboss.deployment.EARStructure">
 <property name="comparatorClassName">org.jboss.system.deployers.LegacyDeploymentContextComparator</property>
 <!-- uncomment to disable xml validation property name="useValidation">false</property -->
 </bean>

 <!-- application.xml parsing deployer -->
 <bean name="AppParsingDeployer" class="org.jboss.deployment.AppParsingDeployer">
 <!-- uncomment to disable xml validation property name="useValidation">false</property -->
 <!-- in case xml validation is disabled, it's also better to turn off schema validation property name="useSchemaValidation">false</property -->
 </bean>

Since the application.xml is parsed twice during deployment. For now I left it commented. There is a test in the testsuite for this issue but it has been commented out and I also left it commented out for now.

Having to modify different properties in different services to enable/disable a feature like this is not nice. It would be better to have something like a system property for this. What do you think?

[aloubyansky]

The test is org.jboss.test.util.test.SchedulerUnitTestCase::testExternalServiceJar()

[adrian.brock]

Why don't you write it as:

<bean name="EARStructureDeployer" class="org.jboss.deployment.EARStructure">
 <property name="comparatorClassName">org.jboss.system.deployers.LegacyDeploymentContextComparator</property>
 <!-- uncomment to disable xml validation property name="useValidation">false</property -->
 </bean>

 <!-- application.xml parsing deployer -->
 <bean name="AppParsingDeployer" class="org.jboss.deployment.AppParsingDeployer">
 <property name="useValidation"><inject bean="EARStructureDeployer" property="useValidation"/></property>
 </bean>

[aloubyansky]

Makes sense, committed. Thanks.