JBAS-5233 - Logging synchronous cluster wide RPC calls as DE

[galder.zamarreno]

JBAS-5233

My idea is to have log messages shown in that JIRA logged as DEBUG rather than TRACE. These include:

log.trace("callMethodOnCluster(true), objName="+objName
 +", methodName="+methodName+", members="+jgotherMembers);
...
log.trace("callMethodOnCluster(false), objName="+objName
 +", methodName="+methodName+", members="+members);
...
log.trace("Ignoring non-received response: "+response);

[galder.zamarreno]

Thoughts anyone?

[brian.stansberry]

Yes, please just put boring long format URLs in your posts, the short version above doesn't work. ;)

[brian.stansberry]

Seriously, though, I don't like logging all that at DEBUG. Perhaps the "Ignoring non-received response message" at debug, and include more info about the call in the msg so you have context.

But run tests-clustering-non-http before putting that in and see what it does to the logs first.

[galder.zamarreno]

Yes, please just put boring long format URLs in your posts, the short version above doesn't work. ;)

Good shout! I thought they're working fine. Not enough testing on my side... :|

There you go: http://jira.jboss.com/jira/browse/JBAS-5233

Seriously, though, I don't like logging all that at DEBUG. Perhaps the "Ignoring non-received response message" at debug, and include more info about the call in the msg so you have context.

But run tests-clustering-non-http before putting that in and see what it does to the logs first.

Ok, that sounds fair enough. It's "Ignoring non-received response message" the one I'm really interested in anyway.

Ok with running the tests too,