HAJNDI access of NamingContext.localServer

[starksm64]

As part of JBNAME-8 to add security for sensitive operations, I really need to remove access to the public static localServer variable of the org.jnp.interfaces.NamingContext class. It looks like the only current user of this outside of the naming project is the org.jboss.ha.jndi.HAJNDI class which implements the Naming server interface.

I'm going to add a static Naming getLocalServer() accessor that can have a permission check, so HAJNDI naming will have to be updated to use this once the 5.0.0.CR3 jnpserver release is out. I'll do the update when I switch over the jbossas version of jnpserver.

For the related TODO in the HAJNDI code we really should be injecting the Naming instance. When I integrate the next jnpserver version I will be switching the naming service configuration to be an mc -beans.xml deployment.

[brian.stansberry]

Sounds good.

For the related TODO in the HAJNDI code we really should be injecting the Naming instance. When I integrate the next jnpserver version I will be switching the naming service configuration to be an mc -beans.xml deployment.

When you change the naming service config to -beans.xml, do you intend to add the injection into DetachedHANamingService, or shall I add a JIRA to handle that myself?

I'll also be converting the hajndi-service.xml back to a -beans.xml for GA, so it's convenient enough for me to add the injection when I do that.

[starksm64]

Create the jira and someone will get to it. I'll most likely get to it since I'll need to get the all config running for the smoke/naming tests in jbossas.

[brian.stansberry]

https://jira.jboss.org/jira/browse/JBAS-6023

[brian.stansberry]

Scott, I'd done JBAS-6023 (inject Naming into HA-JNDI) but it got reverted. I'm about to reapply it, but since your extract of the naming service from conf/jboss-service.xml isn't being reapplied, I'm now doing the injection from a legacy mbean rather than a pojo:

<property name="localNamingInstance"><inject bean="jboss:service=NamingBeanImpl" property="namingInstance"/></property>

If you ever redo the pojoization of the naming service, we'll need to change that to:

<property name="localNamingInstance"><inject bean="LocalNamingBean" property="namingInstance"/></property>

in the following files:

cluster/src/etc/hajndi-jboss-beans.xml
testsuite/src/resources/cluster/ejb2/passexp/partition-passexp-jboss-beans.xml
testsuite/src/resources/cluster/partition/partition-restart-jboss-beans.xml

[starksm64]

Ok.