ReplicationInterceptor incorrect behaviour in rollback

[octopus]

When transaction is being rolled back there's a NPE in afterCompletion:

[OrderedSynchronizationHandler] failed calling afterCompletion() on org.jboss.cache.interceptors.Repli
cationInterceptor$SynchronizationHandler@16b724d
java.lang.NullPointerException
 at org.jboss.cache.interceptors.ReplicationInterceptor$SynchronizationHandler.afterCompletion(ReplicationIntercep
tor.java:252)
 at org.jboss.cache.interceptors.OrderedSynchronizationHandler.afterCompletion(OrderedSynchronizationHandler.java:
79)

in the following code (ReplicationInterceptor$SynchronizationHandler.afterCompletion):

 case Status.STATUS_ROLLEDBACK:
 if(log.isDebugEnabled())
 log.debug("afterCompletion(): rolling back transaction");
 if(modifications.size() > 0) {

modifications here is null because it's only initialized in beforeCompletion() which is not always executed (for example, when setRollbackOnly() was called).

[belaban]

Thanks, fixed in CVS head (added check for modifications == null)

Bela