-
1. Re: overriding LRUAlgorithm
kkalmbach Mar 1, 2005 3:54 PM (in response to kkalmbach)One more thing I did. Most of the Algorithms I use are in our own packages, so methods with pacakge scope are not visable. Since I pass in the NodeEntry to shouldEvictNode, I modified NodeEntry to allow other packages to read some info..
32c32 < long getModifiedTimeStamp() --- > public long getModifiedTimeStamp() 62c62 < Fqn getFqn() --- > public Fqn getFqn()
If these could get merged into the real code, it would help out my modifications a lot.
-Kevin -
2. Re: overriding LRUAlgorithm
ben.wang Mar 2, 2005 9:37 AM (in response to kkalmbach)Kevin,
Let me look at your change once 1.2.1 is out to see if it makes sense.
Thanks,
-Ben -
3. Re: overriding LRUAlgorithm
kkalmbach Apr 15, 2005 10:12 AM (in response to kkalmbach)Any word yet on getting this these changes in the code?
Thanks
-Kevin -
4. Re: overriding LRUAlgorithm
ben.wang Apr 18, 2005 2:56 AM (in response to kkalmbach)Kevin,
Sorry that I have dropped the ball. :-)
I have just applied the patch and check them into the latest JBossCache (note not under jboss-head, though).
Please allow one day and check them out to verify.
Thanks,
-ben -
5. Re: overriding LRUAlgorithm
kkalmbach Apr 18, 2005 9:58 AM (in response to kkalmbach)Everything looks great. Thanks for doing that.
You do anything but "drop the ball". This is probably the most responsive forum I have ever run across. Quick, correct answers, super fast code fixes etc.
You guys are the best. Thanks again.
-Kevin -
6. Re: overriding LRUAlgorithm
kkalmbach Apr 27, 2005 10:07 AM (in response to kkalmbach)I finally got around to looking at the changes you put in and I found one small problem.
In NodeEntry.java, you changed the access level from package to public on
getModifiedTimeStamp() and
setModifiedTimeStamp(long)
Can you make getFQN() public as well.
I'm not sure right off if the setModifiedTimestamp needs to be public or not, but the 2 get's make sense to me.
Thanks again for all your work.
-Kevin