Working with TreeSet / checkSetRecursion bug? [v2.0 alpha]

[chasta]

Hi,
This regards a bug (?) in v2.0 alpha that'll affect only the case of storing a sorted set (e.g. TreeSet) in PojoCache. Now, the documentation specifies that "The Set interface maps to java.util.HashSet implementation", but does that mean the user should never store i.e. TreeSets (e.g., as a data member) in the PojoCache ?

If not, this probably is a bug:

CollectionClassHandler.checkSetRecursion() does a remove() to the Set with itslef. However, since a SortedSet looks for a member using comparisons and will cast the given key (for removal) to Comparable. and a SortedSet does not implement Comparable, a ClassCastException will occur and escape the Cache code.

Using a custom "ComparableSortedSet" which inherits from SortedSet and adds an implementation for Comaprable, everything seems to work.

I think this can be pretty easily handled in the PojoCache code. Do you agree? Should I file a bug?

[genman]

Really, POJO cache needs a proper SortedSet and Map. There's already a bug you can vote on.

If I'm feeling inspired, I might work on this myself...

[genman]

And yes, your work around would be helpful, but if the underlying data is not sorted property, I don't really see it working very well...

[ben.wang]

Yes, support for different flavor of Collection classes in PojoCache has been in my mind for a while. TO fully address this, I have just created a jira and put my thought in there:

http://jira.jboss.com/jira/browse/JBCACHE-893

Please check it out. Of course, as genman mentioned, if you want to your own flavor of SortedSet, you will probably need sorted node underneath for performance.

As for the CCE, you can file a bug for future reference and a junit case will be nice as well.