Possible bug with putForExternalRead in 3.0.1

[soee]

We are currently testing hibernate 3.3.1 with jbosscache 3.0.1

Most of the time it works fine, but sometimes it just pauses for 20 seconds.
i traced it to lock waits in putForExternalRead() which according to the javadoc, shouldn't wait for locks.

I think this line is missing in CacheInvocationDelegate.putForExternalRead() :
getInvocationContext().getOptionOverrides().setLockAcquisitionTimeout(0);

[manik]

Back to my old mantra - have you got a unit test for this? :-) It should be easy enough to write one and test whether pFER() waits for locks - have a tx acquire the lock and then suspend the tx, then try the pFER().

Disabling lock acquisition does not happen in the CacheInvocationDelegate, but in the locking interceptor instead. e.g. PessimisticLockInterceptor:

 @Override
 protected Object handlePutKeyValueCommand(InvocationContext ctx, PutKeyValueCommand command) throws Throwable
 {
 return handlePutCommand(ctx, command, false);
 }

 @Override
 protected Object handlePutForExternalReadCommand(InvocationContext ctx, PutForExternalReadCommand command) throws Throwable
 {
 return handlePutCommand(ctx, command, true);
 }

 private Object handlePutCommand(InvocationContext ctx, DataCommand command, boolean zeroAcquisitionTimeout)
 throws Throwable
 {
 ....
 }

You are right though that this seems to have been missed out in the MVCCLockingInterceptor.

Could you confirm that you saw this problem with MVCC and not PL/OL?

[manik]

Just raised a JIRA for this JBCACHE-1450.

[soee]

Sorry for the missing test case :)

But yes, it was with MVCC locking (did not try Pessimistic or Optimistic).

[soee]

Already fixed on HEAD i can see.. Thanks !