4 Replies Latest reply on May 5, 2003 8:44 AM by casadelnorte

    JSTL-sql tag & datasource

    emil

      Hello,
      I'm using JSTL SQL tag to make selects on Jsp pages with a Sybase Datasource. Using JBoss 3.0.6 everything works fine.

      Now I'm doing the same with JBoss 3.2.0: I've changed the sybase-ds.xml with my own settings and the JBossManagedConnectionPool started with no errors.
      I've tried to view pages retriving data and everything seems ok like before (all pages works fine), but now I've got this warning in dos shell (one per select):

      WARN [WrappedConnection] Closing a statement you left open, please do your own housekeeping

      what does it mean? SQL tag release automatically connection objects... so what's wrong?

        • 1. Re: JSTL-sql tag & datasource
          davidjencks

          How do you know the jstl tag is releasing the connection? Are you sure nothing else is getting a connection handle?

          There might be a bug in jboss, but so far this message has always been correct.

          • 2. Re: JSTL-sql tag & datasource
            emil

            > How do you know the jstl tag is releasing the
            > connection?

            I'm not sure really but consider this:

            - the same page with the same datasource on Jboss 3.0.x doesn't produce this worning

            - JSTL spec say: "A Connection object is obtained and released before the action
            completes."

            > Are you sure nothing else is getting a
            > connection handle?

            yes

            > There might be a bug in jboss, but so far this
            > message has always been correct.

            infact threre are two possibilities: until version 3.0.7 there was a bug that doesn't produce the warning message or in version 3.2.0 there is a bug that produce the warning message

            • 3. Re: JSTL-sql tag & datasource
              davidjencks

              The message is new. I'll say it again, there have been many people saying "this message is totally wrong, I'm closing all my connections". Then, later, they have _all_ said "I looked again, and found the connection I wasn't closing" They usually also say "Now the resource leaks in my app are fewer!"

              I would not believe the jstl spec. Look at their code.

              • 4. Re: JSTL-sql tag & datasource

                Just FYI - I see the same error message in 3.2.0 even without using the JSTL, with a test application/server that uses only a simple query where my statement is closed in the page. I suspect there's something in the pool but haven't had time to look into it. Cheers!