Fix for PerInstanceAdvice.java

[neil_g_avery]

It would repeatedly reinitialize itself on every invocation because the
"initialized" flag wasnt being set. Net result was very slow performance when using PER_INSTANCE scoping.

neil.
ps. I wasnt sure where to put this.
PerInstanceAdvice.java

public Object invoke(Invocation invocation) throws Throwable
{
Object targetObject = invocation.getTargetObject();
if (targetObject == null) return invocation.invokeNext(); // static method call or static field call

Advised advised = (Advised)targetObject;
ClassInstanceAdvisor advisor = (ClassInstanceAdvisor)advised._getInstanceAdvisor();
Object aspect = advisor.getPerInstanceAspect(aspectDefinition);
if (!initialized)
{
init(adviceName, aspect.getClass());
>>>> initialized = true;
}
Method advice = resolveAdvice(invocation);
Object[] args = {invocation};

try
{
return advice.invoke(aspect, args);
}
catch (InvocationTargetException e)
{
throw e.getCause(); //To change body of catch statement use Options | File Templates.
}
}

[kabirkhan]

Thanks!

I updated our cvs with your fix. I also added it to PerJoinpointAdvice. What sort of performance do you see with the fix in?

Cheers,

Kabir

[neil_g_avery]

performance went from 2,000/sec to around 2,000,000/sec - pretty dramatic. HProf showed that init() is introspecting the class to interrogate its attributes, methods etc. This also involves alot of string manip.

Any idea when the next release of jboss-aop will be ?
-neil

[bill.burke]

Thanks Neil!

Bill

[bill.burke]

oh...

check jira.jboss.com under the jboss aop project. You'll see a roadmap that tells you what versions will be released when.