aopc doesn't allow duplicate classes in classpath?

[ryan.campbell]

The AOP compiler doesn't allow a class being woven to exist in the classpath more than once.

On line 340 of org.jboss.aop.standalone.Compiler

if (!classUrlFile.equals(infoFile))
 {
 System.out.println("[warning] Trying to compile " + info.getFile() + " and found it also within " + classUrl.getFile() + " will not proceed. ");
 return;
 }

So if I have an org/jboss/Foo in my src, and org/jboss/Foo also happens to be in a jar in my classpath, it will be skipped. Why is this?

[kabirkhan]

I believe this is to make absolutely certain that there is no confusion about which file should receive the modified bytes

[ryan.campbell]

Ok, thanks. This check is also present in the JBossRetro weaver, so I'm trying to understand why we need it there.

Adrian, could we remove this check from jbossretro? It seems that the src element of the jbossretro task is sufficient for identifying which class is being woven?

[adrian.brock]

The check looks irrelevant for JBossRetro.
You already know what you want to modify.

It might be worthwhile leaving it as a warning (when verbose is enabled)
in case it does cause unexpected problems.