Final feature for AOP/MC integration

[adrian.brock]

This should be the last feature for AOP/MC integration.

The rest of the work will then be making sure all the tests work
and the we turn the prototype into some real code. :-)

The final test is:
InterceptorWithAnnotationDependencyTestCase

The basic idea is that if I do:

@SecurityDomain("MyDomain")
public class POJO {}

Then "MyDomain" should act as a dependency because SecurityDomain
has been annotated like this:

@Dependency(name="domain")
public @interface SecurityDomain
{
 String domain();
}

This is currently failing for two reasons:

1) There is no support for this obviously :-)
2) The attributes of the annotations in the microcontainer overrides
are not getting processed

[kabirkhan]

Is MC for Java 5 only? i.e. am I allowed to call something like the following from the AOPClassAdapter on the annotation proxies stored in the metadata repository?

Object annotation = //get from repository
Class[] interfaces = annotation.getInterfaces();
for (int i = 0 ; i < interfaces.length ; i++)
{
 Dependency dep = interfaces[ i ].getAnnotation(Dependency.class);
}

Or should I access this via the type info stuff?

[kabirkhan]

And if this is not for > JDK 5, how do we

a) Get hold of the annotation types dependencies
b) set them up

[adrian.brock]

It is upto you.
We can backport what we like to JBoss4/AOP1.3

For the rest:
http://wiki.jboss.org/wiki/Wiki.jsp?page=JBossRetro
which I'd like to unify with the AOP stuff.

[starksm64]

I think we need to look at allowing jdk5 constructs with runtime compatibility with jdk1.4.x using jbossretro. It has a mapping for many of the jdk5 specific Class additions. The only currently missing capabilities I know of are the call context related methods. We just need to validate this approach works.

[kabirkhan]

I've got it working, but will hold off commiting until I know I won't break the build

[kabirkhan]

I've tried to get this to work with real annotations as well:

@Test
@TestAnnotationDependency(data="Dependency")
public class AnnotatedSimpleBeanImpl extends SimpleBeanImpl
{
}

...
 <bean name="AnnotatedIntercepted" class="org.jboss.test.microcontainer.support.AnnotatedSimpleBeanImpl"/>
...

However, the annotations don't get populated? In AOPClassAdapter:

 AnnotationValue[] annotations = classInfo.getAnnotations();

annotations is of zero length

[adrian.brock]

Like I said, this whole thing needs implementing.
This includes annotations coming from aop metadata or
the metadata repository.

[kabirkhan]

I can certainly have the AOPClassAdapter do this. But I think you sound like you want the ClassInfo stuff to do this "transparently"?

[kabirkhan]

This feature has now been implemented. I am using the AOPClassAdapter for now.

It supports

Class annotations via xml
Real annotations on class
Property annotations via xml
Real annotations on methods

[kabirkhan]

I am using the AOPClassAdapter for now.

= I did not make any changes to ClassInfo