Removing dependency on concurrent.jar

[kabirkhan]

Manik requested that I look into making AOP 2.0 independent of concurrent.jar. I've replaces all references to EDU.oswego classes with their java.util.concurrent counteparts.

All works fine, apart from org.jboss.aop.proxy.ProxyFactory.createInterfaceProxy, which instantiates a org.jboss.aop.proxy.Proxy which has a field of type GUID(), which uses a SynchronizedLong behind the scenes:

ava.lang.NoClassDefFoundError: EDU/oswego/cs/dl/util/concurrent/SynchronizedLong
 at org.jboss.util.id.UID.<clinit>(UID.java:56)
 at org.jboss.util.id.VMID.create(VMID.java:258)
 at org.jboss.util.id.VMID.getInstance(VMID.java:222)
 at org.jboss.util.id.GUID.<init>(GUID.java:64)
 at org.jboss.aop.proxy.ProxyFactory.createInterfaceProxy(ProxyFactory.java:62)
 at org.jboss.test.aop.proxy.ProxyTestCase.testProxy(ProxyTestCase.java:101)

Is making the jboss.util stuff use a java.util.concurrent.atomic.AtomicLong instead an option?

The only other alternative I can see would be to use something other than a GUID in this place.

[starksm64]

That would mean making the jboss-common jar drop the concurrent dependency. We should create a 2.2.x to do this and leave the 2.0.x common codebase as is.

[kabirkhan]

Who owns common?

[starksm64]

Dimitris, me. I'll start the 2.2.x today.

[starksm64]

I created a 2.0 branch and updated the trunk to a 2.2.0.SNAPSHOT that has no dependency on the oswego concurrent classes. Still need to validate the thread pool changes before a release can be made.

[kabirkhan]

I cannot see the snapshot in the repository?

[starksm64]

There is one failure in the updated BasicThreadPool tests that I need to figure out how to implement before the snapshot can be put out. I'll post when its out.

[starksm64]

Its been uploaded to https://snapshots.jboss.org/maven2//jboss/jboss-common-core/2.2.0-SNAPSHOT/

[kabirkhan]

I copied this across to the old thirdparty repository http://repository.jboss.com/jboss/common-core/2.2.0.snapshot/

I don't think there is a way to make the old builds get the snapshots from Maven?

[kabirkhan]

The retroed version is at http://repository.jboss.com/jboss/common-core-14/2.2.0.snapshot/

[kabirkhan]

The cruisecontrol runs have been failing, while looking like the tests have been run. The underlying problem was that the JDK 1.4 tests were not set up to run against the retroed version of common-core. This has been fixed

[kabirkhan]

Scott/Dimitris

Are there any plans for a properly tagged common-core 2.2.0 release soon? I want to release aop alpha5 soon

[starksm64]

You have been testing the snapshot release? No changes have gone in so no reason why the ga cannot be made.

[kabirkhan]

It works fine with AOP 2.0. Beyond that I have not done any other tests. The original GUID issue works fine