jboss/test-1.0.4GA broke tests

[flavia.rainone]

After updating the version of jboss-test.jar from 1.0.3.GA to 1.0.4.GA, I started getting a bunch of security permission failures.

Does anybody know if this is expected? Should I start running the tests with a security manager? (this will also include changes to the hudson test suite conf)

I haven't found any docs on this test libarary change, but, if there is any, a url link is more than welcome :)

[starksm64]

You have to be running with a security manager to see permission failures. Create a bug report with a test that fails before/after as there should not be any change in behavior as far as I know.

[anil.saldhana]

It needs to be ensured that by default the following call:

System.setSecurityManager(SecurityManager sm)

does not exist in the test infrastructure anywhere (aop or jbosstest).

[anil.saldhana]

JBossTest 1.0.3 was released 9 months ago:
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/test/tags/

The test code has not had major changes.

The only change I see that Adrian made was to make the SecurityManager setup methods static.
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/test/trunk/src/main/java/org/jboss/test/AbstractTestCaseWithSetup.java?r1=62401&r2=62649

So if you say that an upgrade of JBossTest from 1.0.3 to 1.0.4 introduces the security manager, then you may be affected by this change that Adrian has:
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/test/trunk/src/test/java/org/jboss/test/security/test/NothingSecurityUnitTestCase.java?view=log

The right person to answer is Adrian. :)

[flavia.rainone]

Thank's for the replies :)

I'm doing a release of JBoss AOP and basically, I have to update the library versions to the latest ones before closing the release.

Now, after taking a look at the release date of jboss-test 1.0.4.GA, I see that there is something wrong. Since it has been released on September, this version should already be being used by JBoss AOP previous release...

If it is not updated, it is because there is really something wrong. So now we need an answer from Adrian and from Kabir to know what is going on :)

Taking all this into consideration, I'll do the release with the 1.0.3GA version of the library.

[anil.saldhana]

From Adrian's commit message, it seems that the old security policy (maybe test 1.0.3) was too lenient and he made it more stringent. So even with JBossTest 1.0.3, you may already be running under a security manager for your AOP tests with a relaxed policy.

[flavia.rainone]

Unfortunately, I can't see any security policy being enabled in the AOP tests.
So, I'm assuming that there is no security manager enabled.

[flavia.rainone]

I have found out why Kabir hasn't used jboss-test 1.0.4GA on the previous relase.

This is the comment of a commit he did a while ago:

Revert back to test 1.0.3.GA since 1.0.4.GA is not in the repository

[adrian.brock]

The right person to answer is Adrian. :)

I can't answer because there is nothiing specific in the question.

After updating the version of jboss-test.jar from 1.0.3.GA to 1.0.4.GA, I started getting a bunch of security permission failures.

Does anybody know if this is expected?

P.S. I didn't change the way this works by default. I just added a better way
to configure alternative security poliicies.

Most likely it is the chage to the codesource checking that has caught you out.
i.e. previously you weren't testing with the proper privileges for the tests.
This would indicate you are missing some privileged blocks.