-
30. Re: Reimplementing ClassPools for AS
adrian.brock Jan 13, 2009 11:05 AM (in response to kabirkhan)That is the default implementation for any classloader.
i.e. fall back to class.getClassLoader()
The jboss-classloader Module integration does something different:
http://fisheye.jboss.org/browse/JBossAS/projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/policy/ClassLoaderPolicyModule.java?r1=78356&r2=82814 -
31. Re: Reimplementing ClassPools for AS
kabirkhan Jan 13, 2009 11:07 AM (in response to kabirkhan)In case I wasn't clear, I don't want the class to be loaded
-
32. Re: Reimplementing ClassPools for AS
kabirkhan Jan 13, 2009 11:08 AM (in response to kabirkhan)Ooops, I missed your reply. I'll try the snapshot now that it has been spelled out for me :-)
-
33. Re: Reimplementing ClassPools for AS
kabirkhan Jan 13, 2009 12:03 PM (in response to kabirkhan)I found a few problems. I will try to add these to your test
-
34. Re: Reimplementing ClassPools for AS
kabirkhan Jan 13, 2009 2:12 PM (in response to kabirkhan)I have added some failing tests to https://svn.jboss.org/repos/jbossas/projects/jboss-cl/trunk/classloading/src/test/java/org/jboss/test/classloading/dependency/test/ModuleClassLoadingUnitTestCase.java
It mainly seems to be a problem when modules/packages have versions -
35. Re: Reimplementing ClassPools for AS
adrian.brock Jan 14, 2009 4:42 AM (in response to kabirkhan)"kabir.khan@jboss.com" wrote:
I have added some failing tests to https://svn.jboss.org/repos/jbossas/projects/jboss-cl/trunk/classloading/src/test/java/org/jboss/test/classloading/dependency/test/ModuleClassLoadingUnitTestCase.java
It mainly seems to be a problem when modules/packages have versions
Yep, I found that myself after I left the office last night.
I won't port your test to the 2.0 branch since I already have my own. ;-)
It was using the wrong findLoader method
i.e. it was doing an importAll=true search all the time
instead of using rules specific to the classloaderIndex: classloader/src/main/java/org/jboss/classloader/spi/base/BaseClassLoader.java =================================================================== --- classloader/src/main/java/org/jboss/classloader/spi/base/BaseClassLoader.java (revision 82854) +++ classloader/src/main/java/org/jboss/classloader/spi/base/BaseClassLoader.java (working copy) @@ -370,7 +370,7 @@ ClassLoaderUtils.checkClassName(className); String path = ClassLoaderUtils.classNameToPath(className); - Loader loader = domain.findLoader(path); + Loader loader = domain.findLoader(this, path, basePolicy.isImportAll(), true); if (loader == null) throw new ClassNotFoundException("Class " + className + " not found from " + this);
I've upl,oaded a new 2.0.2-SNAPSHOT with this fix included. -
36. Re: Reimplementing ClassPools for AS
kabirkhan Jan 14, 2009 3:06 PM (in response to kabirkhan)Thanks, that works fine