Help needed to create a patch.

[zerotolerance]

Hi,

We use Jboss AS 5.1.0 GA with hibernate and AOP.
While starting JBoss AS, AOP kicks in to do its thing with some hibernate classes. There we get an error.

After getting my hands dirty with some debugging and coding I think I have found the reason and solution for this error.

The file 'org.jboss.aop.proxy.ClassProxyFactory.java' contains a line (325 in my eclipse) that contains:

if (!Modifier.isPublic(m.getModifiers()) || Modifier.isStatic(m.getModifiers())) continue;

A method like:

public final Serializable getKey(){...}

(See class org.hibernate.collection.AbstractPersistentCollection.java)

Will be changed by the code following the if statement.

My guess would be that the line should be changed to:

if (!Modifier.isPublic(m.getModifiers()) || Modifier.isFinal(m.getModifiers()) || Modifier.isStatic(m.getModifiers())) continue;

I would like to test this but have no clue as how to build aop for JBoss AS myself.

So what I'm asking is : Can one of you direct me to documentation on how to do this or with the above description build it for me?

As this is a blocking issue for me I will keep looking for documentation myself in the hope that soon I will get an answer from one of you.

Kind regards,
Werner van Mook

[jaikiran]

Werner,

These wiki will get you started:

http://www.jboss.org/community/wiki/BuildingJBossAOPFromSubversion

http://www.jboss.org/community/wiki/JBossAOP

http://www.jboss.org/community/wiki/HowToContribute

http://jboss.org/help/submittingpatches.html

Feel free to post back if you need any more help in creating the patch.

[zerotolerance]

Hi,

First of all thanks for the information.

I now have the aop sourcecode from the repository and want to compile the code.

This is where I have the code from:
http://anonsvn.jboss.org/repos/jbossas/projects/aop

There is a build directory with a build.xml file.
according to http://www.jboss.org/community/wiki/BuildingJBossAOPFromSubversion I should run build.bat (I have a windows system)
If I run this I get the following error message: (See below)

Running the build script from eclipse or the command line is giving the same result.

Anybody any idea on what is wrong?
Could it be that there is something wrong with jrockit? I never installed it as far as I know.

Regards,
Werner

Buildfile: C:\Java\workspace\jbossaop\build\build.xml
verify-environment:
 [echo] Apache Ant version 1.7.0 compiled on December 13 2006
 [echo] Java version 1.6
init-maven-parent:
[maven:install] [INFO] Installing C:\Java\workspace\jbossaop\pom.xml to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop-parent\2.1.0-SNAPSHOT\jboss-aop-parent-2.1.0-SNAPSHOT.pom
init:
 [echo] Using maven version located at C:\Java\workspace\jbossaop/tools/maven
set-jrockit:
maven-build-install:
 [echo] jrockit:
 [java] [INFO] Scanning for projects...
 [java] [INFO] Reactor build order:
 [java] [INFO] JBoss AOP Parent POM
 [java] [INFO] JBoss AOP Framework
 [java] [INFO] JBoss AOP Pluggable Instrumentor
 [java] [INFO] JBoss AOP Aspects
 [java] [INFO] JBoss AOP AS Integration Core
 [java] [INFO] JBoss AOP AS Integration JMX
 [java] [INFO] JBoss AOP AS Integration MC
 [java] [INFO] JBoss AOP Helper
 [java] [INFO] JBoss AOP Deployers
 [java] [INFO] JBoss AOP Distribution Build
 [java] WAGON_VERSION: 1.0-beta-2
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] Building JBoss AOP Parent POM
 [java] [INFO] task-segment: [install]
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [site:attach-descriptor]
 [java] [INFO] Preparing source:jar
 [java] [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [source:jar {execution: attach-sources}]
 [java] [INFO] [install:install]
 [java] [INFO] Installing C:\Java\workspace\jbossaop\pom.xml to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop-parent\2.1.0-SNAPSHOT\jboss-aop-parent-2.1.0-SNAPSHOT.pom
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] Building JBoss AOP Framework
 [java] [INFO] task-segment: [install]
 [java] [INFO] ------------------------------------------------------------------------
 [java] Downloading: http://repo1.maven.org/maven2/apache-xerces/xml-apis/2.9.1/xml-apis-2.9.1.pom
 [java] Downloading: http://repo1.maven.org/maven2/jboss/profiler/jvmti/jboss-profiler-jvmti/1.0.0.CR5/jboss-profiler-jvmti-1.0.0.CR5.pom
 [java] Downloading: http://repo1.maven.org/maven2/jboss/jboss-test/1.0.3.GA/jboss-test-1.0.3.GA.pom
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [resources:resources]
 [java] [INFO] Using default encoding to copy filtered resources.
 [java] [INFO] [compiler:compile]
 [java] [INFO] Nothing to compile - all classes are up to date
 [java] [INFO] [resources:testResources]
 [java] [INFO] Using default encoding to copy filtered resources.
 [java] [INFO] [compiler:testCompile]
 [java] [INFO] Compiling 3 source files to C:\Java\workspace\jbossaop\aop\target\test-classes
 [java] [INFO] [surefire:test]
 [java] [INFO] Tests are skipped.
 [java] [INFO] [jar:jar]
 [java] [INFO] Preparing source:jar
 [java] [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [source:jar {execution: attach-sources}]
 [java] [INFO] Building jar: C:\Java\workspace\jbossaop\aop\target\jboss-aop-sources.jar
 [java] [INFO] [jar:test-jar {execution: create-test-jar}]
 [java] [INFO] Building jar: C:\Java\workspace\jbossaop\aop\target\jboss-aop-tests.jar
 [java] [INFO] [assembly:attached {execution: jdk50-client}]
 [java] [INFO] Reading assembly descriptor: src/assembly/client.xml
 [java] [INFO] Building jar: C:\Java\workspace\jbossaop\aop\target\jboss-aop-client.jar
 [java] [INFO] [assembly:attached {execution: client-sources}]
 [java] [INFO] Reading assembly descriptor: src/assembly/client-sources.xml
 [java] [INFO] Building jar: C:\Java\workspace\jbossaop\aop\target\jboss-aop-client-sources.jar
 [java] [INFO] [assembly:attached {execution: single}]
 [java] [INFO] Reading assembly descriptor: src/assembly/single.xml
 [java] [INFO] Processing DependencySet (output=null)
 [java] [INFO] Building jar: C:\Java\workspace\jbossaop\aop\target\jboss-aop-single.jar
 [java] [INFO] [antrun:run {execution: copy-output-jars}]
 [java] [INFO] Executing tasks
 [java] [copy] Copying 1 file to C:\Java\workspace\jbossaop\aop\target\lib
 [java] [copy] Copying 1 file to C:\Java\workspace\jbossaop\aop\target\lib
 [java] [copy] Copying 1 file to C:\Java\workspace\jbossaop\aop\target\lib
 [java] [copy] Copying 1 file to C:\Java\workspace\jbossaop\aop\target\lib
 [java] [INFO] Executed tasks
 [java] [INFO] [install:install]
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aop\target\jboss-aop.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop\2.1.0-SNAPSHOT\jboss-aop-2.1.0-SNAPSHOT.jar
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aop\target\jboss-aop-sources.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop\2.1.0-SNAPSHOT\jboss-aop-2.1.0-SNAPSHOT-sources.jar
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aop\target\jboss-aop-tests.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop\2.1.0-SNAPSHOT\jboss-aop-2.1.0-SNAPSHOT-tests.jar
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aop\target\jboss-aop-client.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop\2.1.0-SNAPSHOT\jboss-aop-2.1.0-SNAPSHOT-client.jar
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aop\target\jboss-aop-client-sources.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop\2.1.0-SNAPSHOT\jboss-aop-2.1.0-SNAPSHOT-client-sources.jar
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aop\target\jboss-aop-single.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop\2.1.0-SNAPSHOT\jboss-aop-2.1.0-SNAPSHOT-single.jar
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] Building JBoss AOP Pluggable Instrumentor
 [java] [INFO] task-segment: [install]
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [resources:resources]
 [java] [INFO] Using default encoding to copy filtered resources.
 [java] [INFO] [compiler:compile]
 [java] [INFO] Nothing to compile - all classes are up to date
 [java] [INFO] [resources:testResources]
 [java] [INFO] Using default encoding to copy filtered resources.
 [java] [INFO] [compiler:testCompile]
 [java] [INFO] No sources to compile
 [java] [INFO] [surefire:test]
 [java] [INFO] No tests to run.
 [java] [INFO] [jar:jar]
 [java] [INFO] Preparing source:jar
 [java] [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [source:jar {execution: attach-sources}]
 [java] [INFO] Building jar: C:\Java\workspace\jbossaop\pluggable-instrumentor\target\pluggable-instrumentor-sources.jar
 [java] [INFO] [install:install]
 [java] [INFO] Installing C:\Java\workspace\jbossaop\pluggable-instrumentor\target\pluggable-instrumentor.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\pluggable-instrumentor\2.1.0-SNAPSHOT\pluggable-instrumentor-2.1.0-SNAPSHOT.jar
 [java] [INFO] Installing C:\Java\workspace\jbossaop\pluggable-instrumentor\target\pluggable-instrumentor-sources.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\pluggable-instrumentor\2.1.0-SNAPSHOT\pluggable-instrumentor-2.1.0-SNAPSHOT-sources.jar
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] Building JBoss AOP Aspects
 [java] [INFO] task-segment: [install]
 [java] [INFO] ------------------------------------------------------------------------
 [java] Downloading: http://repo1.maven.org/maven2/org/jboss/javaee/jboss-jca-api/1.5.0.CR2/jboss-jca-api-1.5.0.CR2.pom
 [java] Downloading: http://repo1.maven.org/maven2/org/jboss/javaee/jboss-servlet-api/2.5.0.CR2/jboss-servlet-api-2.5.0.CR2.pom
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [resources:resources]
 [java] [INFO] Using default encoding to copy filtered resources.
 [java] [INFO] [compiler:compile]
 [java] [INFO] Nothing to compile - all classes are up to date
 [java] [INFO] [resources:testResources]
 [java] [INFO] Using default encoding to copy filtered resources.
 [java] [INFO] [compiler:testCompile]
 [java] [INFO] Nothing to compile - all classes are up to date
 [java] [INFO] [surefire:test]
 [java] [INFO] Tests are skipped.
 [java] [INFO] [jar:jar]
 [java] [INFO] Preparing source:jar
 [java] [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [source:jar {execution: attach-sources}]
 [java] [INFO] Building jar: C:\Java\workspace\jbossaop\aspects\target\jboss-aop-aspects-sources.jar
 [java] [INFO] [install:install]
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aspects\target\jboss-aop-aspects.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop-aspects\2.1.0-SNAPSHOT\jboss-aop-aspects-2.1.0-SNAPSHOT.jar
 [java] [INFO] Installing C:\Java\workspace\jbossaop\aspects\target\jboss-aop-aspects-sources.jar to C:\Documents and Settings\mook\.m2\repository\org\jboss\aop\jboss-aop-aspects\2.1.0-SNAPSHOT\jboss-aop-aspects-2.1.0-SNAPSHOT-sources.jar
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] Building JBoss AOP AS Integration Core
 [java] [INFO] task-segment: [install]
 [java] [INFO] ------------------------------------------------------------------------
 [java] Downloading: http://repo1.maven.org/maven2/org/jboss/jbossas/jboss-as-system-jmx/5.0.0.CR1/jboss-as-system-jmx-5.0.0.CR1.pom
 [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
 [java] [INFO] [resources:resources]
 [java] [INFO] Using default encoding to copy filtered resources.
 [java] [INFO] [compiler:compile]
 [java] [INFO] Compiling 35 source files to C:\Java\workspace\jbossaop\asintegration-core\target\classes
 [java] [INFO] ------------------------------------------------------------------------
 [java] [ERROR] BUILD FAILURE
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] Compilation failure
 [java] C:\Java\workspace\jbossaop\asintegration-core\src\main\java\org\jboss\aop\asintegration\core\AspectManagerServiceDelegate.java:[60,30] cannot find symbol
 [java] symbol : class ServerConfig
 [java] location: package org.jboss.system.server
 [java] C:\Java\workspace\jbossaop\asintegration-core\src\main\java\org\jboss\aop\asintegration\core\AspectManagerServiceDelegate.java:[230,49] cannot find symbol
 [java] symbol : variable ServerConfig
 [java] location: class org.jboss.aop.asintegration.core.AspectManagerServiceDelegate
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] For more information, run Maven with the -e switch
 [java] [INFO] ------------------------------------------------------------------------
 [java] [INFO] Total time: 45 seconds
 [java] [INFO] Finished at: Wed Aug 12 10:04:42 CEST 2009
 [java] [INFO] Final Memory: 25M/54M
 [java] [INFO] ------------------------------------------------------------------------
 [java] Java Result: 1

BUILD FAILED
C:\Java\workspace\jbossaop\build\build.xml:135: Unable to build maven modules. See maven output for details.

Total time: 48 seconds

[kabirkhan]

The build requires that you have jrockit installed and set -Djrockit.home=/path/to/jrockit. However, that is harder said than done now that jrockit no longer seems to be available for download following the acquisition of BEA by Oracle.

AOP trunk has this jrockit dependency as a profile in the build, so you could try copying that. Or you could try doing your work in trunk, as I am releasing 2.1.4 today, which will probably be the last 2.1.x release.

[zerotolerance]

At the moment I'm suffering from an information overload.

I got the jboss aop code from:
92142 [anonsvn.jboss.org/repos/jbossas/projects/aop, Trunk:trunk]

I even succeeded in building the jar needed for my project (jboss-aop.jar)
It seems to solve my problems.

Now I would like to create an official patch for this and here is where the trouble starts for me.

I have read loads of information from the above links and think I have to take the following steps:

1) sign a developer contract. (done)
2) Get the software to patch (from https://svn/jboss.org/repos/...)
3) Make the changes in the software.
4) build the software.
5) test it.
6) create a patch in JIRA.
7) upload a jar in JIRA.
8) wait for QA to respond.

I'm sure of the first and third step ;-)

So before messing up the complete JBoss development process I would like to know:

Can someone tell me if I'm correct with the above steps or what is missing?

Kind regards,
Werner

[kabirkhan]

Hi Werner,

1)
I accepted your developer contract thing, but since we have had very few external committers to jboss aop and this process is new, I am unsure about how it works. I will make some enquiries, but the lead of jboss.org is on holiday.

2-5)
For testing we do two things
a) Make sure that the tests in aop/ itself do not fail with your changes, i.e.

cd aop/
ant -f build-tests-jdk50.xml tests

b) Make sure the test does not break the in AS tests
Check out jboss application server version 5.1.0.GA and build it

svn co https://svn.jboss.org/repos/jbossas/tags/JBoss_5_1_0_GA/
cd JBoss_5_1_0_GA/build
./build.sh
cd output/jboss-5.1.0/bin

Update the aop version in the built AS.
Set up the pluggable-instrumentor.jar in the built bin/ directory and modify the run.sh to use it (if you need more detail here let me know)
Start the server:

./run.sh -c all

In another console build and run the tests

cd JBoss_5_1_0_GA/testsuite
./build.sh
./build.sh test -Dtest=aop
./build.sh smoke-tests-raw

Once that is done you can create a diff and upload it to JIRA and we'll take it from there :-)

Hope this helps

[zerotolerance]

Hi Kabir Kahn,

I'm not sure on what to change in aop.

I need to start in svn.jboss.org/repos.
And then what?

/jbossas/projects/aop/tags/JBOSS_AOP_2_1_4_GA ?

This can be retrieved by svn co https:// and the above?

I already build jboss 5.1.1GA and now need to do the pluggable-instrumentor.jar thingy.

How does that work.

Sorry for my lack of knowledge but I'm new to this patching thing.

Best regards,
Werner

[kabirkhan]

Hi there,

From the bin/directory of the built as 5.1.1.GA do
cp ../server/all/deployers/jboss-aop-jboss5.deployer/pluggable-instrumentor.jar .

Then modify run.sh (or run.bat if you're on Windows)
# Setup JBoss specific properties
JAVA_OPTS="-Dprogram.name=$PROGNAME $JAVA_OPTS"
#Add this line
JAVA_OPTS="-javaagent:pluggable-instrumentor.jar $JAVA_OPTS"

The work should be done against:
https://svn.jboss.org/repos/jbossas/projects/aop/branches/Branch_2_1/
and
https://svn.jboss.org/repos/jbossas/projects/aop/trunk

I see I answered the wrong thing for your previous post with the build failure, thinking it was to do with JRockit. The builds should work out of the box for the mentioned branches, if you have any problems building please post them here.

Ask as much as you like, I don't mind helping you helping us :-)

[zerotolerance]

Hi,

Back again.

I got both Branch and trunk.
Changed my code there and did a build like:

Branch_2_1: cd build
./build.sh

and

trunk: cd build
./build.sh

In both cases I get an error that tells me 6 artifacts are missing.
These are amongst others:
jboss-test-1.0.3.GA.jar,
jboss-logging-log4j-2.0.5.GA.jar

I had this before and had to download these files myself and then install them using maven.
Is there an easier way to do that?

Regards,
Werner

[kabirkhan]

Aha, I remember now :-) You need to set up the jboss repositories as mentioned here http://www.jboss.org/community/wiki/MavenSettings

[kabirkhan]

I am not sure what has happened to your contributor agreement, would you mind trying to fill it in again?

Sorry for the trouble

[zerotolerance]

Hi,

I just got back (this morning) a reply that my application as contributor has been approved.
Are you sure I should apply for it again?

Regards,
Werner

[zerotolerance]

Hi,

Running the tests of Branch_2_1 build_tests_jdk50.xml before changing the code gives me the following error:

_run-javaagent-test:
 [echo] Running precedence with instrumentor org.jboss.aop.instrument.GeneratedAdvisorInstrumentor
 [junit] Running org.jboss.test.aop.precedence.NoPrecedenceTestCase
 [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0,922 sec
 [junit] Running org.jboss.test.aop.precedence.PrecedenceTester
 [junit] Tests run: 10, Failures: 6, Errors: 0, Time elapsed: 1,094 sec
 [junit] Test org.jboss.test.aop.precedence.PrecedenceTester FAILED

and

_run-javaagent-test:
 [echo] Running precedence with instrumentor org.jboss.aop.instrument.ClassicInstrumentor
 [junit] Running org.jboss.test.aop.precedence.NoPrecedenceTestCase
 [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0,719 sec
 [junit] Running org.jboss.test.aop.precedence.PrecedenceTester
 [junit] Tests run: 10, Failures: 6, Errors: 0, Time elapsed: 0,86 sec
 [junit] Test org.jboss.test.aop.precedence.PrecedenceTester FAILED

and

not-woven-tests:
[annotationc] Working directory ignored when same JVM is used.
[annotationc] [compiled] C:\Java\workspace\Branch_2_1\aop\target\test-classes\org\jboss\test\aop\annotationc\BytecodePOJO$InnerClass.class
[annotationc] [compiled] C:\Java\workspace\Branch_2_1\aop\target\test-classes\org\jboss\test\aop\annotationc\BytecodePOJO$StaticInnerClass.class
[annotationc] [compiled] C:\Java\workspace\Branch_2_1\aop\target\test-classes\org\jboss\test\aop\annotationc\BytecodePOJO.class
 [junit] Running org.jboss.test.aop.annotationc.AnnotationTester
 [junit] Tests run: 13, Failures: 0, Errors: 0, Time elapsed: 0,375 sec
 [junit] Running org.jboss.test.aop.bridgemethodnotwoven.BridgeMethodTestCase
 [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,578 sec
 [junit] Running org.jboss.test.aop.ejb3dependencies.EJB3CompatibilityTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,266 sec
 [junit] Running org.jboss.test.aop.methodhashing.MethodHashingTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,094 sec
 [junit] Running org.jboss.test.aop.pointcut.PointcutTestCase
 [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0,515 sec
 [junit] Running org.jboss.test.aop.proxy.ProxyTestCase
 [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 1,376 sec
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithAspectsInVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,813 sec
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithAspectsOutOfVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0,14 sec
 [junit] Test org.jboss.test.aop.proxy.ReSerializeContainerProxyWithAspectsOutOfVmTestCase FAILED
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithInterceptorsInVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,781 sec
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithInterceptorsOutOfVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0,141 sec
 [junit] Test org.jboss.test.aop.proxy.ReSerializeContainerProxyWithInterceptorsOutOfVmTestCase FAILED
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithNonInitialisedAdvicesInVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1,031 sec
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithNonInitialisedAdvicesOutOfVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0,157 sec
 [junit] Test org.jboss.test.aop.proxy.ReSerializeContainerProxyWithNonInitialisedAdvicesOutOfVmTestCase FAILED
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithScopedAspectsInVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,86 sec
 [junit] Running org.jboss.test.aop.proxy.ReSerializeContainerProxyWithScopedAspectsOutOfVmTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0,156 sec
 [junit] Test org.jboss.test.aop.proxy.ReSerializeContainerProxyWithScopedAspectsOutOfVmTestCase FAILED

There are more like these!

It is now at:

_run-precompiled-test:
 [echo] Compiling annotationoverride with optimized=true and instrumentor org.jboss.aop.instrument.ClassicInstrumentor

For more than 1 hour and nothing seems to happen.

Any idea?


Regards,
Werner

[zerotolerance]

Hi,

Also build the trunk of aop without my code changes.
While testing (build-tests-jdk50.xml tests) the same failures and behavior occurs (Stops responding while compiling) as with testing the Branch_2_1 part.

It all happens before I changed anything.

Just did a svn co ...... , build it with build/build.sh and then aop/build-tests-jdk50.xml tests.
(but then the equivalent in eclipse ;-).

<background music of tv series "twilight zone">
I now have two processes doing something mysterious.
<\background music of tv series "twilight zone">

As I will be on holiday for the next three weeks I will leave it at this and come back to you after my holiday.

Best regards,
Werner

[kabirkhan]

You can ignore the Precedence test failures, and we will try to look later. The background for this is that the ordering is influences by the OS the JVM is running on. Our automated test runs are on Linux and Flavia is on Linux. I used to be on Windows, but have been on OS X for a year. Since you're the first Windows user to run these in a long time that is probably that cropping up again.

Same for the XXXXOutOfVmTestCases. They used to work on Windows, but have not been run there for a long time. The issue is looking up the 'java' executable.

However, the annotationoverride test should not take that long, it should only take a few seconds (as should all the tests). If you have not already done so, try quitting and starting it all again. If that does not work, try taking a thread dump (I think it is CTRL-BREAK on Windows).

For your own purposes when getting up to speed, you can disable tests by commenting them out in base-tests.xml.