[zerotolerance]

Hi,

probably my last posting of today.

It seems that I have build and tested both the Branch and trunk of aop successfully. I have exactly the same failures with or without my change.

The next step would be copying the changed aop jar files to jboss AS.
My question would then be:

From where? would that be the Branch or the trunk?

Best regards,
Werner

[kabirkhan]

Great :-)

From Branch_2_1 (since that is the closest version to what is in AS. To test trunk needs a bit more work)

[zerotolerance]

Hi,

Can't help it. I wanted to know if it all worked so tried it at home too.

Build everything on my own Mac OS X.

Replaced the aop jars in the JBoss build and ran the tests.

Before placing all kinds of stack traces and logging output I want to ask something.

When running the tests I can see all kinds of exceptions flying across the jboss log window while the window in which I started the tests keeps saying that the tests are successful!

This happens in both the ./build.sh test -Dtest=aop and ./build.sh smoke-tests-raw.

Is that expected behaviour?

Kind reagrds,
Werner

[zerotolerance]

Hi,

back from holiday.

I have build and started JBoss 5.1.0. GA as mentioned in earlier postings.
I did NOT add my rebuild classes/jars.
I wanted to test how jboss AS would react when I would run the tests on a clean build.

So executing : build test -Dtest=aop results in the following output:

C:\JBoss_5_1_0_GA\testsuite>build test -Dtest=aop
Calling ..\tools\bin\ant.bat test -Dtest aop
Buildfile: build.xml

test:
 [mkdir] Created dir: C:\JBoss_5_1_0_GA\testsuite\output\log
 [junit] Running org.jboss.test.aop.test.AOPUnitTestCase
 [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 13,743 sec
 [junit] Running org.jboss.test.aop.test.AnnotatedTestCase
 [junit] Tests run: 13, Failures: 0, Errors: 0, Time elapsed: 3,058 sec
 [junit] Running org.jboss.test.aop.test.DeployersInitialTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,93 sec
 [junit] Running org.jboss.test.aop.test.ExtenderTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,867 sec
 [junit] Running org.jboss.test.aop.test.JMXUnitTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,631 sec
 [junit] Running org.jboss.test.aop.test.MicrocontainerDefaultAnnotationUnitTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,741 sec
 [junit] Running org.jboss.test.aop.test.MicrocontainerJMXUnitTestCase
 [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1,229 sec
 [junit] Running org.jboss.test.aop.test.NotWovenScopedDependencyUnitTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 1,135 sec
 [junit] Running org.jboss.test.aop.test.ObservableUnitTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 7,234 sec
 [junit] Running org.jboss.test.aop.test.ProxyCacheTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 68,999 sec
 [junit] Running org.jboss.test.aop.test.RemotingUnitTestCase
 [junit] Tests run: 4, Failures: 0, Errors: 2, Time elapsed: 9,121 sec
 [junit] Test org.jboss.test.aop.test.RemotingUnitTestCase FAILED
 [junit] Running org.jboss.test.aop.test.ScopedAnnotatedTestCase
 [junit] Tests run: 15, Failures: 0, Errors: 0, Time elapsed: 10,973 sec
 [junit] Running org.jboss.test.aop.test.ScopedAttachUnitTestCase
 [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 4,255 sec
 [junit] Running org.jboss.test.aop.test.ScopedEarWithClassesInWebInfTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 3,203 sec
 [junit] Running org.jboss.test.aop.test.ScopedExtenderBaseLoadedScopedNoParentDelegationTestCase

 [junit] Tests run: 7, Failures: 0, Errors: 4, Time elapsed: 3,799 sec
 [junit] Test org.jboss.test.aop.test.ScopedExtenderBaseLoadedScopedNoParentDelegationTestCase FAILED
 [junit] Running org.jboss.test.aop.test.ScopedExtenderBaseLoadedScopedParentDelegationTestCase
 [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 20,596 sec
 [junit] Running org.jboss.test.aop.test.ScopedExtenderBaseNotLoadedScopedNoParentDelegationTestCase
 [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 3,045 sec
 [junit] Running org.jboss.test.aop.test.ScopedExtenderBaseNotLoadedScopedParentDelegationTestCase
 [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 3,219 sec
 [junit] Running org.jboss.test.aop.test.ScopedUnitTestCase
 [junit] Tests run: 16, Failures: 0, Errors: 0, Time elapsed: 5,118 sec
 [junit] Running org.jboss.test.aop.test.ScopedWovenDependencyTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 1,13 sec
 [junit] Running org.jboss.test.aop.test.SecurityUnitTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 9,906 sec
 [junit] Running org.jboss.test.aop.test.SimpleBeanUnitTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 2,967 sec
 [junit] Running org.jboss.test.aop.test.TxLockUnitTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 17,739 sec
 [junit] Running org.jboss.test.aop.test.TxUnitTestCase
 [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 9,34 sec
 [junit] Running org.jboss.test.aop.test.VersionedObjectUnitTestCase
 [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 8,98 sec

BUILD SUCCESSFUL
Total time: 4 minutes 7 seconds

C:\JBoss_5_1_0_GA\testsuite>

As you can see testing already failed with a clean build. (6 errors in total).

How can I find out what is going wrong?

Kind regards,
Werner

[zerotolerance]

I found out what the problem was.
I had my JBOSS_HOME environment variable point to a real JBoss installation instead of the one that was going to be tested.

After fixing that I did a rebuild of the JBoss environment and the testsuite and did the tests again.

This time the tests did not give me any errors or failures.

I did see some exceptions going by in the JBoss console.
Some of the exceptions were:
Missing dependency,
IllegalState,
NoSuchEntity and
InvalidSelector

The tests came out OK so I guess I'm done testing?

I do need to create a diff now if I'm correct.
So my next question would be of what?

Kind regards,
Werner

[jaikiran]

I do need to create a diff now if I'm correct.
So my next question would be of what?

Going by your first post, the file that needs change is org.jboss.aop.proxy.ClassProxyFactory.java. So the steps would be (now that you are done with building a clean JBoss AOP code):

1) Do your change (fix) in the org.jboss.aop.proxy.ClassProxyFactory.java
2) Create a simple testcase which ensures that this fix works. You can check some of the existing testcases to see how you can write a simple new one.
3) Run the tests with your fix included to ensure there are no regressions
4) Create the svn diff as explained here http://jboss.org/help/submittingpatches.html

That's it :)

And if you have any more questions, feel free to post them in this forum.